Message-ID: <gh-pgjdbc-pgjdbc-3923@github.com>
From: "Praveen7294 (@Praveen7294)" <noreply+Praveen7294@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 02 Feb 2026 09:59:25 +0000
Subject: [pgjdbc/pgjdbc] issue #3923: Formatting issue detected by updated Checkstyle EmptyLineSeparator check
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Id: 126603513
X-GitHub-Author-Login: Praveen7294
X-GitHub-Issue: 3923
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-State: closed
X-GitHub-Type: issue
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/3923
Content-Type: text/plain; charset=utf-8

The pgjdbc project is currently used as a test input dependency in Checkstyle CI (CircleCI). While working on Checkstyle, I recently enhanced the `EmptyLineSeparatorCheck` to include handling for `ENUM_CONSTANT_DEF` token.

After this improvement, an existing formatting issue in the pgjdbc codebase is now detected by Checkstyle.

### Affected location:
`PGProperty.java`, around line 756
https://github.com/pgjdbc/pgjdbc/blob/1ac8d99a0042dd8250475aed477bdbfed565a7c1/pgjdbc/src/main/java/org/postgresql/PGProperty.java#L756

### Details:
According to the `EmptyLineSeparator` rule, there should not be more than one empty line before a block comment. The enum constant definition in this file violates this rule.

Previously, this violation was not reported because `ENUM_CONSTANT_DEF` token was not covered by the Checkstyle check. With the updated implementation, the violation is now correctly flagged.

### Why this matters:
Since pgjdbc is used in Checkstyle CI as an external test project, this violation may cause Checkstyle builds to fail when newer versions of Checkstyle are used. Aligning the code with the rule helps maintain compatibility and avoids CI noise.

### Suggested change:
Remove the extra empty line before the block comment in the enum constant definition to comply with the `EmptyLineSeparator` rule.