pgjdbc/pgjdbc GitHub issues and pull requests (mirror)help / color / mirror / Atom feed
[pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl 6+ messages / 2 participants [nested] [flat]
* [pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl @ 2026-02-05 11:20 "davecramer (@davecramer)" <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: davecramer (@davecramer) @ 2026-02-05 11:20 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl @ 2026-02-05 11:33 "vlsi (@vlsi)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: vlsi (@vlsi) @ 2026-02-05 11:33 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:224) This looks wrong. It should better be `protocolMajor =...` `protocolMinor =...` ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl @ 2026-02-05 11:47 "davecramer (@davecramer)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: davecramer (@davecramer) @ 2026-02-05 11:47 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:224) ? ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl @ 2026-02-05 11:48 "vlsi (@vlsi)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: vlsi (@vlsi) @ 2026-02-05 11:48 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:224) I meant major vs minor ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl @ 2026-02-05 12:24 "vlsi (@vlsi)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: vlsi (@vlsi) @ 2026-02-05 12:24 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:224) Just for consistency, could we order maror/minor the same across both if branches? ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl @ 2026-02-05 12:50 "davecramer (@davecramer)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: davecramer (@davecramer) @ 2026-02-05 12:50 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:224) Yea, I thought that was weird too ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-02-05 12:50 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-02-05 11:20 [pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl "davecramer (@davecramer)" <[email protected]> 2026-02-05 11:33 ` "vlsi (@vlsi)" <[email protected]> 2026-02-05 11:47 ` "davecramer (@davecramer)" <[email protected]> 2026-02-05 11:48 ` "vlsi (@vlsi)" <[email protected]> 2026-02-05 12:24 ` "vlsi (@vlsi)" <[email protected]> 2026-02-05 12:50 ` "davecramer (@davecramer)" <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox