Subject: Re: [pgjdbc/pgjdbc] PR #3929: fix small issues in ConnectionFactoryImpl

From: "vlsi (@vlsi)" <[email-masked]>
Date: Thu, 05 Feb 2026 11:33:29 +0000

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:224)

This looks wrong. It should better be `protocolMajor =...` `protocolMinor =...`

---

From: "davecramer (@davecramer)" <[email-masked]>
Date: Thu, 05 Feb 2026 11:47:13 +0000

?

---

From: "vlsi (@vlsi)" <[email-masked]>
Date: Thu, 05 Feb 2026 11:48:17 +0000

I meant major vs minor

---

From: "vlsi (@vlsi)" <[email-masked]>
Date: Thu, 05 Feb 2026 12:24:24 +0000

Just for consistency, could we order maror/minor the same across both if branches?

---

From: "davecramer (@davecramer)" <[email-masked]>
Date: Thu, 05 Feb 2026 12:50:55 +0000

Yea, I thought that was weird too