pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  
help / color / mirror / Atom feed
[pgjdbc/pgjdbc] PR #3931: Migrate to Shadow 9
6+ messages / 2 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3931: Migrate to Shadow 9
@ 2026-02-06 05:31  "Goooler (@Goooler)" <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: Goooler (@Goooler) @ 2026-02-06 05:31 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

```
OLD: old.jar
NEW: new.jar

 JAR   │ old     │ new     │ diff
───────┼─────────┼─────────┼──────────
 class │ 2.1 MiB │ 2.1 MiB │ +1.2 KiB
 other │   473 B │   473 B │      0 B
───────┼─────────┼─────────┼──────────
 total │ 2.1 MiB │ 2.1 MiB │ +1.2 KiB

 CLASSES │ old  │ new  │ diff
─────────┼──────┼──────┼───────────
 classes │  481 │  481 │ 0 (+0 -0)
 methods │ 5873 │ 5873 │ 0 (+0 -0)
  fields │ 1945 │ 1945 │ 0 (+0 -0)

=================
====   JAR   ====
=================

 size     │ diff     │ path
──────────┼──────────┼──────────────────────────────────────────────────────────────────
 19.2 KiB │    +31 B │ ∆ org/postgresql/Driver.class
 24.9 KiB │    +38 B │ ∆ org/postgresql/PGProperty.class
  6.1 KiB │    +10 B │ ∆ org/postgresql/copy/CopyManager.class
  2.3 KiB │    +23 B │ ∆ org/postgresql/core/CachedQuery.class
  7.4 KiB │    -27 B │ ∆ org/postgresql/core/Encoding.class
 16.8 KiB │     -1 B │ ∆ org/postgresql/core/PGStream.class
 22.7 KiB │     -2 B │ ∆ org/postgresql/core/Parser.class
  2.7 KiB │    +39 B │ ∆ org/postgresql/core/QueryExecutorCloseAction.class
 32.4 KiB │    +37 B │ ∆ org/postgresql/core/v3/ConnectionFactoryImpl.class
    708 B │    +29 B │ ∆ org/postgresql/core/v3/QueryExecutorImpl$4.class
 66.9 KiB │    +77 B │ ∆ org/postgresql/core/v3/QueryExecutorImpl.class
 15.8 KiB │    +16 B │ ∆ org/postgresql/core/v3/SimpleParameterList.class
  8.6 KiB │     -2 B │ ∆ org/postgresql/core/v3/replication/V3PGReplicationStream.class
  2.1 KiB │    +36 B │ ∆ org/postgresql/ds/PGConnectionPoolDataSource.class
 10.1 KiB │    +35 B │ ∆ org/postgresql/ds/PGPoolingDataSource.class
  2.1 KiB │    +36 B │ ∆ org/postgresql/ds/PGSimpleDataSource.class
    856 B │    +29 B │ ∆ org/postgresql/ds/common/BaseDataSource$1.class
  7.2 KiB │    +38 B │ ∆ org/postgresql/gss/GssAction.class
  6.2 KiB │     -1 B │ ∆ org/postgresql/gss/GssEncAction.class
  6.8 KiB │     -3 B │ ∆ org/postgresql/gss/MakeGSS.class
  7.4 KiB │     -1 B │ ∆ org/postgresql/jdbc/AbstractBlobClob.class
 12.7 KiB │    +44 B │ ∆ org/postgresql/jdbc/ArrayDecoding.class
  5.4 KiB │    +29 B │ ∆ org/postgresql/jdbc/ArrayEncoding$13.class
  6.2 KiB │    +29 B │ ∆ org/postgresql/jdbc/ArrayEncoding.class
  7.9 KiB │    +24 B │ ∆ org/postgresql/jdbc/BatchResultHandler.class
 14.9 KiB │    -43 B │ ∆ org/postgresql/jdbc/EscapedFunctions.class
 14.9 KiB │    -17 B │ ∆ org/postgresql/jdbc/EscapedFunctions2.class
  1.7 KiB │    +45 B │ ∆ org/postgresql/jdbc/FieldMetadata.class
 13.7 KiB │    +52 B │ ∆ org/postgresql/jdbc/PgArray.class
  2.2 KiB │    +23 B │ ∆ org/postgresql/jdbc/PgBlob.class
 31.8 KiB │    +14 B │ ∆ org/postgresql/jdbc/PgCallableStatement.class
 54.5 KiB │    +78 B │ ∆ org/postgresql/jdbc/PgConnection.class
 86.1 KiB │    +84 B │ ∆ org/postgresql/jdbc/PgDatabaseMetaData.class
 45.9 KiB │    +49 B │ ∆ org/postgresql/jdbc/PgPreparedStatement.class
 96.2 KiB │    +32 B │ ∆ org/postgresql/jdbc/PgResultSet.class
 11.7 KiB │    +20 B │ ∆ org/postgresql/jdbc/PgResultSetMetaData.class
 11.9 KiB │     -5 B │ ∆ org/postgresql/jdbc/PgSQLXML.class
 31.9 KiB │     -3 B │ ∆ org/postgresql/jdbc/PgStatement.class
    1 KiB │    +33 B │ ∆ org/postgresql/jdbc/TimestampUtils$ParsedTimestamp.class
 36.5 KiB │    +75 B │ ∆ org/postgresql/jdbc/TimestampUtils.class
   26 KiB │    +76 B │ ∆ org/postgresql/jdbc/TypeInfoCache.class
  7.2 KiB │     -2 B │ ∆ org/postgresql/jdbcurlresolver/PgPassParser.class
  8.1 KiB │     -4 B │ ∆ org/postgresql/jdbcurlresolver/PgServiceConfParser.class
  2.4 KiB │    +44 B │ ∆ org/postgresql/osgi/PGBundleActivator.class
 10.4 KiB │     -4 B │ ∆ org/postgresql/ssl/LazyKeyManager.class
  9.5 KiB │     -5 B │ ∆ org/postgresql/ssl/LibPQFactory.class
  7.9 KiB │    +38 B │ ∆ org/postgresql/sspi/SSPIClient.class
   39 KiB │    -13 B │ ∆ org/postgresql/translation/messages_bg.class
   13 KiB │    -13 B │ ∆ org/postgresql/translation/messages_cs.class
 23.9 KiB │    -13 B │ ∆ org/postgresql/translation/messages_de.class
 23.8 KiB │    -13 B │ ∆ org/postgresql/translation/messages_fr.class
 22.7 KiB │    -13 B │ ∆ org/postgresql/translation/messages_it.class
 48.8 KiB │    -13 B │ ∆ org/postgresql/translation/messages_ja.class
 11.4 KiB │    -13 B │ ∆ org/postgresql/translation/messages_pl.class
 27.4 KiB │    -14 B │ ∆ org/postgresql/translation/messages_pt_BR.class
   20 KiB │    -14 B │ ∆ org/postgresql/translation/messages_ru.class
 26.7 KiB │    -13 B │ ∆ org/postgresql/translation/messages_sr.class
 26.7 KiB │    -13 B │ ∆ org/postgresql/translation/messages_tr.class
 17.3 KiB │    -13 B │ ∆ org/postgresql/translation/messages_zh_CN.class
 17.3 KiB │    -13 B │ ∆ org/postgresql/translation/messages_zh_TW.class
  8.7 KiB │    +20 B │ ∆ org/postgresql/util/ByteConverter.class
  3.4 KiB │    +36 B │ ∆ org/postgresql/util/LogWriterHandler.class
  1.3 KiB │    +20 B │ ∆ org/postgresql/util/NumberParser.class
 10.1 KiB │    +18 B │ ∆ org/postgresql/util/PGInterval.class
  1.4 KiB │    +36 B │ ∆ org/postgresql/util/PGJDBCMain.class
  6.2 KiB │    -11 B │ ∆ org/postgresql/util/PSQLState.class
  5.7 KiB │    +23 B │ ∆ org/postgresql/util/StreamWrapper.class
 13.4 KiB │    +29 B │ ∆ org/postgresql/xa/PGXAConnection.class
  1.7 KiB │    +36 B │ ∆ org/postgresql/xa/PGXADataSource.class
  5.1 KiB │    +28 B │ ∆ org/postgresql/xml/DefaultPGXmlFactoryFactory.class
──────────┼──────────┼──────────────────────────────────────────────────────────────────
  1.2 MiB │ +1.2 KiB │ (total)
```

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document?
* [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?

<!-- You can erase any parts of this template not applicable to your Pull Request. -->

### New Feature Submissions:

1. [x] Does your submission pass tests?
2. [x] Does `./gradlew styleCheck` pass ?
3. [ ] Have you added your new test classes to an existing test suite in alphabetical order?

### Changes to Existing Features:

* [ ] Does this break existing behaviour? If so please explain.
* [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
* [ ] Have you written new tests for your core changes, as applicable?
* [ ] Have you successfully run tests with your changes locally?


^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3931: Migrate to Shadow 9
@ 2026-02-06 06:09  "vlsi (@vlsi)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: vlsi (@vlsi) @ 2026-02-06 06:09 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Shadow 9 requires Gradle 9, doesn't it?
https://github.com/GradleUp/shadow?tab=readme-ov-file#compatibility-matrix

For now we are stuck with Gradle 8 due to https://github.com/lburgazzoli/gradle-karaf-plugin/issues/88

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3931: Migrate to Shadow 9
@ 2026-02-06 06:10  "Goooler (@Goooler)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: Goooler (@Goooler) @ 2026-02-06 06:10 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

It requires Gradle 9 from `9.3.x`, I bumped the version to `9.2.2`.

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3931: Migrate to Shadow 9
@ 2026-02-06 06:11  "vlsi (@vlsi)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: vlsi (@vlsi) @ 2026-02-06 06:11 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

What is the diff by the way?
I thought the build was reproducible, so I thought it should produce the same class files across compilations.

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3931: Migrate to Shadow 9
@ 2026-02-06 06:22  "Goooler (@Goooler)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: Goooler (@Goooler) @ 2026-02-06 06:22 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

I think these minor differences are caused by 

- https://github.com/GradleUp/shadow/pull/1694
- https://github.com/GradleUp/shadow/releases/tag/9.1.0

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3931: Migrate to Shadow 9
@ 2026-02-06 06:31  "vlsi (@vlsi)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: vlsi (@vlsi) @ 2026-02-06 06:31 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Thanks a lot

^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2026-02-06 06:31 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-06 05:31 [pgjdbc/pgjdbc] PR #3931: Migrate to Shadow 9 "Goooler (@Goooler)" <[email protected]>
2026-02-06 06:09 ` "vlsi (@vlsi)" <[email protected]>
2026-02-06 06:10 ` "Goooler (@Goooler)" <[email protected]>
2026-02-06 06:11 ` "vlsi (@vlsi)" <[email protected]>
2026-02-06 06:22 ` "Goooler (@Goooler)" <[email protected]>
2026-02-06 06:31 ` "vlsi (@vlsi)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox