Message-ID: <gh-pgjdbc-pgjdbc-3934-rc2783172521@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 09 Feb 2026 15:09:46 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3934: fix non-standard strings failing test for version 19
In-Reply-To: <gh-pgjdbc-pgjdbc-3934@github.com>
References: <gh-pgjdbc-pgjdbc-3934@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2783172521
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7f78d44070c3e349b0d5cd703c69c8b54ecc6fcb
X-GitHub-Issue: 3934
X-GitHub-Line: 473
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/test/jdbc2/PreparedStatementTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3934#discussion_r2783172521
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PreparedStatementTest.java:473)

This looks inversed, doesn't it?
If you assume the test should execute with old versions only, we should have something like assume Maximum ServerVersion here