pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3935: Add assumeServerVersionLessThan  
5+ messages / 2 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3935: Add assumeServerVersionLessThan  
@ 2026-02-09 16:05 "davecramer (@davecramer)" <[email protected]>
  0 siblings, 0 replies; 5+ messages in thread

From: davecramer (@davecramer) @ 2026-02-09 16:05 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

make it easy to run tests that only run on servers less than a version



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3935: Add assumeServerVersionLessThan  
@ 2026-02-09 18:32 ` "vlsi (@vlsi)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: vlsi (@vlsi) @ 2026-02-09 18:32 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

(on pgjdbc/src/main/java/org/postgresql/core/BaseConnection.java:140)

Do we need those on the public API?

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3935: Add assumeServerVersionLessThan  
@ 2026-02-09 18:33 ` "vlsi (@vlsi)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: vlsi (@vlsi) @ 2026-02-09 18:33 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

(on pgjdbc/src/test/java/org/postgresql/jdbc/AbstractArraysTest.java)

This looks like a consequence of an extra method on the interface

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3935: Add assumeServerVersionLessThan  
@ 2026-02-09 18:35 ` "vlsi (@vlsi)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: vlsi (@vlsi) @ 2026-02-09 18:35 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

(on testkit/src/main/java/org/postgresql/test/TestUtil.java:805)

An alternative option could be adding `@DisabledIfServerVersionAbove` (like we have `@DisabledIfServerVersionBelow`) or refactoring `@DisabledIfServerVersionBelow` into `@DisabledIfServerVersionRange(min=..., max=...)`

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3935: Add assumeServerVersionLessThan  
@ 2026-02-09 20:19 ` "davecramer (@davecramer)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: davecramer (@davecramer) @ 2026-02-09 20:19 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Closing in favour of https://github.com/pgjdbc/pgjdbc/pull/3937

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

end of thread, other threads:[~2026-02-09 20:19 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-09 16:05 [pgjdbc/pgjdbc] PR #3935: Add assumeServerVersionLessThan   "davecramer (@davecramer)" <[email protected]>
2026-02-09 18:32 ` "vlsi (@vlsi)" <[email protected]>
2026-02-09 18:33 ` "vlsi (@vlsi)" <[email protected]>
2026-02-09 18:35 ` "vlsi (@vlsi)" <[email protected]>
2026-02-09 20:19 ` "davecramer (@davecramer)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox