pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3939: Add RequireServerVersion annotation for tests
Date: Mon, 23 Feb 2026 11:50:17 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

(on testkit/src/main/java/org/postgresql/test/annotations/EnabledForServerVersionRange.java:33)

There's no check for contradictory specs like `@EnabledForServerVersionRange(lt = "9.4", gt = "10.0")` or specifying both lt and lte simultaneously. Worth at least validating that lt/lte aren't both set, and same for gt/gte.

view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3939: Add RequireServerVersion annotation for tests
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox