Message-ID: <gh-pgjdbc-pgjdbc-3939-rc2840774071@github.com>
From: "sehrope (@sehrope)" <noreply+sehrope@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 23 Feb 2026 13:06:55 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3939: Add RequireServerVersion annotation for tests
In-Reply-To: <gh-pgjdbc-pgjdbc-3939-rc2840448961@github.com>
References: <gh-pgjdbc-pgjdbc-3939@github.com> <gh-pgjdbc-pgjdbc-3939-rc2840448961@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: sehrope
X-GitHub-Comment-Id: 2840774071
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 615c7c027b380ef7189688c05768361c0cbf2553
X-GitHub-Issue: 3939
X-GitHub-Line: 33
X-GitHub-Path: testkit/src/main/java/org/postgresql/test/annotations/EnabledForServerVersionRange.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3939#discussion_r2840774071
Content-Type: text/plain; charset=utf-8

(on testkit/src/main/java/org/postgresql/test/annotations/EnabledForServerVersionRange.java:33)

No I don't like the hidden options with defaults as the entire purpose is to make the determination explicit. That's why I went with separate `lt` and `lte`. Ditto for not having a flag that flips it from "include" to "exclude".

The lt/lte or gt/gte check would be fine to add (the cross one is way more complicated).