pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] PR #3961: fix: use compareTo for LogSequenceNumber comparison
3+ messages / 2 participants
[nested] [flat]
* [pgjdbc/pgjdbc] PR #3961: fix: use compareTo for LogSequenceNumber comparison
@ 2026-03-13 18:58 "vlsi (@vlsi)" <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: vlsi (@vlsi) @ 2026-03-13 18:58 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Previously, processKeepAliveMessage used asLong() for LogSequenceNumber comparison, however, it might produce wrong results since longs in Java are signed.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3961: fix: use compareTo for LogSequenceNumber comparison
@ 2026-03-13 19:00 "vlsi (@vlsi)" <[email protected]>
1 sibling, 0 replies; 3+ messages in thread
From: vlsi (@vlsi) @ 2026-03-13 19:00 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on pgjdbc/src/test/java/org/postgresql/replication/LogicalReplicationStatusTest.java:451)
This should fix flaky failures like
```
Expected: not <LSN{0/100E8CD8}>
but: was <LSN{0/100E8CD8}>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.postgresql.replication.LogicalReplicationStatusTest.keepAliveServerLSNCanBeUsedToAdvanceFlushLSN
```
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3961: fix: use compareTo for LogSequenceNumber comparison
@ 2026-03-13 19:26 "davecramer (@davecramer)" <[email protected]>
1 sibling, 0 replies; 3+ messages in thread
From: davecramer (@davecramer) @ 2026-03-13 19:26 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on pgjdbc/src/test/java/org/postgresql/replication/LogicalReplicationStatusTest.java:451)
nice
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-03-13 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-03-13 18:58 [pgjdbc/pgjdbc] PR #3961: fix: use compareTo for LogSequenceNumber comparison "vlsi (@vlsi)" <[email protected]>
2026-03-13 19:00 ` "vlsi (@vlsi)" <[email protected]>
2026-03-13 19:26 ` "davecramer (@davecramer)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox