Message-ID: <gh-pgjdbc-pgjdbc-3964-c4066140967@github.com>
From: "reda-alaoui (@reda-alaoui)" <noreply+reda-alaoui@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 16 Mar 2026 09:06:21 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3964: Allow setting of KeepAlive options in JDBC driver
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: reda-alaoui
X-GitHub-Comment-Id: 4066140967
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2026-03-16T09:13:13Z
X-GitHub-Issue: 3964
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3964#issuecomment-4066140967
Content-Type: text/plain; charset=utf-8

> 1. Add them to the matrix. Check out [bd572f4](https://github.com/pgjdbc/pgjdbc/commit/bd572f408b315aa91739a60e58c2413770c054cd) as an example

I don't know if you saw it, I added conditional assertions to `ConnectionTest#pGStreamSettings`.

> By the way, do the new settings apply without explicit `SO_KEEPALIVE` activation?

I didn't find any explicit hint about this in the JDK documentation. Because of that, I didn't want to make any assumption neither in the code nor in this project's documentation.