Message-ID: <gh-pgjdbc-pgjdbc-3964-c4075378011@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 17 Mar 2026 14:25:13 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3964: Allow setting of KeepAlive options in JDBC driver
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 4075378011
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3964
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3964#issuecomment-4075378011
Content-Type: text/plain; charset=utf-8

> I don't know if you saw it, I added conditional assertions to ConnectionTest#pGStreamSettings.

It is fine to add assertions to `ConnectionTest`, however, we'd better ensure all the tests are runnable with `keepalive` on, so I would still like to add keepalive to the matrix.

In fact, we could even configure non-default values for the newly added settings for the recent JDKs we have in our matrix.