Message-ID: <gh-pgjdbc-pgjdbc-3964-c4091334951@github.com>
From: "reda-alaoui (@reda-alaoui)" <noreply+reda-alaoui@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 19 Mar 2026 16:09:41 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3964: Allow setting of KeepAlive options in JDBC driver
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: reda-alaoui
X-GitHub-Comment-Id: 4091334951
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2026-03-19T16:09:53Z
X-GitHub-Issue: 3964
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3964#issuecomment-4091334951
Content-Type: text/plain; charset=utf-8

@vlsi I guess this failure is also caused by flakiness?

> Java 8, corretto, PG 17, scram, ssl, windows, server_tz America/New_York, client_tz America/New_York, fr_FR, no_gss, replication, slow_tests, adaptive_fetch, rewrite_batch_inserts, query_timeout 15, autosave conservative, cleanupSavepoints

```
org.postgresql.replication.LogicalReplicationTest > replicationRestartFromLastFeedbackPositionParallelTransaction() failure marker
  Error:   0,6sec org.postgresql.replication.LogicalReplicationTest > replicationRestartFromLastFeedbackPositionParallelTransaction()
  java.lang.AssertionError: When we add feedback about applied lsn to replication stream(in this case it's force update status)after restart consume changes via this slot should be started from last success lsn that we send before via force status update, that why we wait consume both transaction without duplicates
  Expected: "BEGIN\ntable public.test_logic_table: INSERT: pk[integer]:1 name[character varying]:'first tx changes'\nCOMMIT\nBEGIN\ntable public.test_logic_table: INSERT: pk[integer]:2 name[character varying]:'second tx changes'\nCOMMIT"
       but: was "BEGIN\ntable public.test_logic_table: INSERT: pk[integer]:1 name[character varying]:'first tx changes'\nCOMMIT\nBEGIN\ntable public.test_logic_table: INSERT: pk[integer]:1 name[character varying]:'first tx changes'\nCOMMIT"
      at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
      at org.postgresql.replication.LogicalReplicationTest.replicationRestartFromLastFeedbackPositionParallelTransaction(LogicalReplicationTest.java:839)
FAILURE   0,6sec, org.postgresql.replication.LogicalReplicationTest > replicationRestartFromLastFeedbackPositionParallelTransaction()
    java.lang.AssertionError: When we add feedback about applied lsn to replication stream(in this case it's force update status)after restart consume changes via this slot should be started from last success lsn that we send before via force status update, that why we wait consume both transaction without duplicates
    Expected: "BEGIN\ntable public.test_logic_table: INSERT: pk[integer]:1 name[character varying]:'first tx changes'\nCOMMIT\nBEGIN\ntable public.test_logic_table: INSERT: pk[integer]:2 name[character varying]:'second tx changes'\nCOMMIT"
         but: was "BEGIN\ntable public.test_logic_table: INSERT: pk[integer]:1 name[character varying]:'first tx changes'\nCOMMIT\nBEGIN\ntable public.test_logic_table: INSERT: pk[integer]:1 name[character varying]:'first tx changes'\nCOMMIT"
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
        at org.postgresql.replication.LogicalReplicationTest.replicationRestartFromLastFeedbackPositionParallelTransaction(LogicalReplicationTest.java:839)
```