Message-ID: <gh-pgjdbc-pgjdbc-3964-rc2938988635@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 16 Mar 2026 08:59:40 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3964: Allow setting of KeepAlive options in JDBC driver
In-Reply-To: <gh-pgjdbc-pgjdbc-3964-rc2938928765@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com> <gh-pgjdbc-pgjdbc-3964-rc2938928765@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2938988635
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 113b0e34eefce6a93fae808d61b06a97ad0c6272
X-GitHub-Issue: 3964
X-GitHub-Line: 89
X-GitHub-Path: pgjdbc/src/main/java11/org/postgresql/core/ExtendedSocketOptionAccessorImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3964#discussion_r2938988635
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java11/org/postgresql/core/ExtendedSocketOptionAccessorImpl.java:89)

We use the APIs only for the specific socket options, so I'm gravitating to going with direct `ExtendedSocketOptions.FIELD_NAME` usages and just let it fail in the runtime if the JDK misses the option.
We could probably skip the class from forbidden-apis check.