pgjdbc/pgjdbc GitHub issues and pull requests (mirror)help / color / mirror / Atom feed
[pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres 7+ messages / 3 participants [nested] [flat]
* [pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres @ 2026-03-16 07:47 "vlsi (@vlsi)" <[email protected]> 0 siblings, 0 replies; 7+ messages in thread From: vlsi (@vlsi) @ 2026-03-16 07:47 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Fixes https://github.com/pgjdbc/pgjdbc/issues/2845 PG installation takes ~3 mintues. The tests take 12 minutes vs 6 minutes for the regular ubuntu runners. The slowdown is unfortunate, however, it is still faster than Appveyor ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres @ 2026-03-16 08:32 "gitguardian[bot] (bot) (@gitguardian[bot])" <noreply+gitguardian[bot]@github.com> 5 siblings, 0 replies; 7+ messages in thread From: gitguardian[bot] (bot) (@gitguardian[bot]) @ 2026-03-16 08:32 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> #### ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request. Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components. Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard. <details> <summary>🔎 Detected hardcoded secret in your pull request</summary> <br> | GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Password | a15cc136cd2ab97c6517194fc844b6d4f51e894d | .github/workflows/main.yml | [View secret](https://github.com/pgjdbc/pgjdbc/commit/a15cc136cd2ab97c6517194fc844b6d4f51e894d#diff-7829468e86c1cc...) | </details> <details> <summary>🛠 Guidelines to remediate hardcoded secrets</summary> <br> 1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_che...) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_p...). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=...). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_ch...) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&...) to catch secret before it leaves your machine and ease remediation. </details> --- <sup>🦉 [GitGuardian](https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&utm_source=github&...) detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.<br/></sup> ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres @ 2026-03-17 15:48 "vlsi (@vlsi)" <[email protected]> 5 siblings, 0 replies; 7+ messages in thread From: vlsi (@vlsi) @ 2026-03-17 15:48 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> I guess this is feature complete. I guess the main cause of the slowness is the time it takes to establish connections. We could probably add connection caching in the future so parameterized tests reuse connections rather than recreate them for every parameter combination. @bokken , @sehrope , @davecramer , do you have any comments/suggestions/objections? ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres @ 2026-03-17 17:30 "sehrope (@sehrope)" <[email protected]> 5 siblings, 0 replies; 7+ messages in thread From: sehrope (@sehrope) @ 2026-03-17 17:30 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> I'd prefer to have less external dependencies in the repo over time. I took a peek at ikalnytskyi/action-setup-postgres (never hard of it before...) and it does look pretty clean. Though I don't think we need it. I'm not sure we even need to build on Windows / MacOS or test against PostgreSQL running on either. If we just had something that could run our already build jar on those against a Linux PostgreSQL server I think it's enough. That'd solve a lot of the startup issues. ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres @ 2026-03-17 17:33 "vlsi (@vlsi)" <[email protected]> 5 siblings, 0 replies; 7+ messages in thread From: vlsi (@vlsi) @ 2026-03-17 17:33 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Windows tests identified different os behavior regarding sslMode=prefer/allow fallback which look like true os-specific differences to me rather than just ability to build jar on Windows ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres @ 2026-03-17 17:35 "sehrope (@sehrope)" <[email protected]> 5 siblings, 0 replies; 7+ messages in thread From: sehrope (@sehrope) @ 2026-03-17 17:35 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> And this PR touches more than just tests / appveyor. It changes how we handle ssl mode for `prefer`. You should call that in the title and description. ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres @ 2026-03-17 17:45 "vlsi (@vlsi)" <[email protected]> 5 siblings, 0 replies; 7+ messages in thread From: vlsi (@vlsi) @ 2026-03-17 17:45 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> I've extracted `sslMode=allow` handling to https://github.com/pgjdbc/pgjdbc/pull/3973 ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2026-03-17 17:45 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-03-16 07:47 [pgjdbc/pgjdbc] PR #3966: chore: replace Appveyor with ikalnytskyi/action-setup-postgres "vlsi (@vlsi)" <[email protected]> 2026-03-16 08:32 ` "gitguardian[bot] (bot) (@gitguardian[bot])" <noreply+gitguardian[bot]@github.com> 2026-03-17 15:48 ` "vlsi (@vlsi)" <[email protected]> 2026-03-17 17:30 ` "sehrope (@sehrope)" <[email protected]> 2026-03-17 17:33 ` "vlsi (@vlsi)" <[email protected]> 2026-03-17 17:35 ` "sehrope (@sehrope)" <[email protected]> 2026-03-17 17:45 ` "vlsi (@vlsi)" <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox