pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
12+ messages / 3 participants
[nested] [flat]
* [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-22 13:36 "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
0 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-22 13:36 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
…TION ' command.
### All Submissions:
* [ ] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document?
* [ ] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?
<!-- You can erase any parts of this template not applicable to your Pull Request. -->
### New Feature Submissions:
1. [ ] Does your submission pass tests?
2. [ ] Does `./gradlew styleCheck` pass ?
3. [ ] Have you added your new test classes to an existing test suite in alphabetical order?
### Changes to Existing Features:
* [ ] Does this break existing behaviour? If so please explain.
* [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
* [ ] Have you written new tests for your core changes, as applicable?
* [ ] Have you successfully run tests with your changes locally?
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-22 13:36 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-22 13:36 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
fix Enable cursor-based bug, when start transaction by 'START TRANSACTION ' command.
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-22 16:58 ` "davecramer (@davecramer)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: davecramer (@davecramer) @ 2026-03-22 16:58 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
what does this fix? Do you have a way to reproduce it?
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-22 21:22 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-22 21:22 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> what does this fix? Do you have a way to reproduce it?
I reproduce , see https://github.com/PillArmy/army/blob/master/army-example/src/test/java/io/army/temp/PostgreBugRepro...
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-22 21:27 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-22 21:27 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on pgjdbc/src/main/java/org/postgresql/jdbc/PgStatement.java:459)
I reproduce , see https://github.com/PillArmy/army/blob/master/army-example/src/test/java/io/army/temp/PostgreBugRepro...
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-22 21:30 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-22 21:30 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> what does this fix? Do you have a way to reproduce it?
I write the jdbd-postgre , https://github.com/PillArmy/jdbd-postgre , so it clear,I know it
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-22 21:40 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-22 21:40 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
For this bug, I have to do more ,for example :
https://github.com/PillArmy/army/blob/master/army-jdbc/src/main/java/io/army/jdbc/JdbcExecutor.java#...
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-23 09:27 ` "davecramer (@davecramer)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: davecramer (@davecramer) @ 2026-03-23 09:27 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
So I'm curious why are you using start transaction readonly when there is an API for this?
setAutoCommit(false) and setReadOnly(true)
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-23 09:31 ` "vlsi (@vlsi)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: vlsi (@vlsi) @ 2026-03-23 09:31 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Could you add a test case to cover the change?
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-23 09:51 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-23 09:51 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> So I'm curious why are you using start transaction readonly when there is an API for this? setAutoCommit(false) and setReadOnly(true)
Because ,Jdbc js bad design,Starting a database transaction should maintain integrity, so it must be a single SQL statement. This is good design , startTransaction(TransactionOption option).
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-23 09:55 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-23 09:55 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> Could you add a test case to cover the change?
Can I commit one issue, and you write the code ?
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC…
@ 2026-03-23 10:20 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
10 siblings, 0 replies; 12+ messages in thread
From: qinarmy-zoro (@qinarmy-zoro) @ 2026-03-23 10:20 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
I commit one issue，and close the poll request.
see https://github.com/pgjdbc/pgjdbc/issues/3993
^ permalink raw reply [nested|flat] 12+ messages in thread
end of thread, other threads:[~2026-03-23 10:20 UTC | newest]
Thread overview: 12+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-03-22 13:36 [pgjdbc/pgjdbc] PR #3980: fix Enable cursor-based bug, when start transaction by 'START TRANSAC… "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
2026-03-22 13:36 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
2026-03-22 16:58 ` "davecramer (@davecramer)" <[email protected]>
2026-03-22 21:22 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
2026-03-22 21:27 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
2026-03-22 21:30 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
2026-03-22 21:40 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
2026-03-23 09:27 ` "davecramer (@davecramer)" <[email protected]>
2026-03-23 09:31 ` "vlsi (@vlsi)" <[email protected]>
2026-03-23 09:51 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
2026-03-23 09:55 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
2026-03-23 10:20 ` "qinarmy-zoro (@qinarmy-zoro)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox