Message-ID: <gh-pgjdbc-pgjdbc-4016-c4525371096@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sat, 23 May 2026 12:37:04 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #4016: feat: harden protocol reader against desynced streams (#4015)
In-Reply-To: <gh-pgjdbc-pgjdbc-4016@github.com>
References: <gh-pgjdbc-pgjdbc-4016@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 4525371096
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 4016
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/4016#issuecomment-4525371096
Content-Type: text/plain; charset=utf-8

This PR has been open since April 10 and I think it's ready to merge.

The most material recent change: warn is now the default for pgjdbc.protocolViolationBehaviour, so an upgrade cannot turn a previously-working workload into hard connection failures. Issue [#4015](https://github.com/pgjdbc/pgjdbc/issues/4015) itself and a handful of impossible-value checks always fail fast in every mode (they would otherwise reach a NegativeArraySizeException or an indefinite socket read a few lines later). Operators who want broader fail-fast safety opt into fail explicitly. See the updated PR description for the full mode table and rationale.

Planning to merge on Tuesday 26 May unless there's further feedback.