pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #4016: feat: harden protocol reader against desynced streams (#4015)
Date: Tue, 26 May 2026 06:41:58 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

I can split the self-contained `GSSInputStream` packet-size cap if that helps, but the other GSS changes use the same `readMessageLength(...)` plumbing as the rest of the PR, so splitting those would create dependent PRs rather than independent review units.

I agree a structured descriptor may be better eventually. I intentionally kept `readMessageLength(String, ...)` narrow in this PR because the name is only diagnostic text, not protocol dispatch. Adding an enum raises separate design questions around frontend/backend direction, startup/auth state, replication, and context-specific messages. I am trying to keep this PR focused on enforcing bounds, not redesigning message metadata.

view thread (21+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #4016: feat: harden protocol reader against desynced streams (#4015)
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox