Message-ID: <gh-pgjdbc-pgjdbc-4016-rc3293340348@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sat, 23 May 2026 18:54:00 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #4016: feat: harden protocol reader against desynced streams (#4015)
In-Reply-To: <gh-pgjdbc-pgjdbc-4016@github.com>
References: <gh-pgjdbc-pgjdbc-4016@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 3293340348
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 18ef66a5594bac7f828a01c0d59099226945504f
X-GitHub-Issue: 4016
X-GitHub-Line: 828
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/4016#discussion_r3293340348
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:828)

The double-space in "Protocol error.  Session setup failed." is preserved from the original code, but since this is a user-facing error message, it might be worth fixing to a single space while you're touching these lines. (Appears in 3 places.)