Message-ID: <gh-pgjdbc-pgjdbc-4016-rc3293340349@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sat, 23 May 2026 18:54:00 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #4016: feat: harden protocol reader against desynced streams (#4015)
In-Reply-To: <gh-pgjdbc-pgjdbc-4016@github.com>
References: <gh-pgjdbc-pgjdbc-4016@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 3293340349
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: cf796453de1c4d4e6bcef1c593928ba06cf38ce9
X-GitHub-Issue: 4016
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/ProtocolViolationBehaviour.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/4016#discussion_r3293340349
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/ProtocolViolationBehaviour.java)

The class Javadoc says "Default: {@link #WARN}" but the PR description says "Default: `fail`". The code confirms WARN is the default (`fromSystemProperty()` returns WARN on null/empty). The PR description's table has a discrepancy:

> | `fail` (default) | Poison `PGStream` and throw...

One of these is wrong. Looking at the code, WARN is clearly the default. The PR description's table should mark `warn` as the default, not `fail`.