Message-ID: <gh-pgjdbc-pgjdbc-4063-c4420225981@github.com>
From: "sehrope (@sehrope)" <noreply+sehrope@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 11 May 2026 11:24:11 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #4063: fix: getCharacterStream wraps String in StringReader
In-Reply-To: <gh-pgjdbc-pgjdbc-4063@github.com>
References: <gh-pgjdbc-pgjdbc-4063@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: sehrope
X-GitHub-Comment-Id: 4420225981
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 4063
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/4063#issuecomment-4420225981
Content-Type: text/plain; charset=utf-8

Changing the class while still returning a `Reader` is not a breaking change. Anybody that is relying on the exact underlying implementation has been gambling that it will never change. And that user must have been explicitly casting the reader type too. So I doubt this is a problem in the real world and even if it is, it's the user's problem to fix.

This is a purely internal change and does not require maintaining any backwards compatible flag for the old behavior. If we want the change, just change the returned value and that's it.