pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: sehrope (@sehrope) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #4075: docs: restructure site, compatibility page, changelog-driven releases
Date: Tue, 19 May 2026 14:10:14 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
There are more than enough things here that this should be broken up into pieces. More than one of which needs explicit discussion.
RE: support policy. I do not want to support JDK 6 or 7 going forward either. They're both well past EOL.
Any long term security policy commitment (e.g., X years...) needs to be discussed and agreed upon. I'd prefer to handle that offline. Ditto for whether it means we provide a single JDK8+ version that has both fixes and features or separately maintain "fix-only" branches (which has its own issues).
---
I'm also going to ask that we go out of our way to actually read and review all the AI generated text. The submitter is responsible for that. We should not end up with a bunch of emdashes (`—`) all over the docs either. And I don't mean just add that to an AGENTS.md file to not generate them. It's fine to use tools as a baseline for generation, but the submitter is responsible for reading everything that is generated.
I also don't like adding even more custom kotlin gradle code. I haven't stepped through all of it but man there's at lot here. Fetching CVE lists, using JGit process the git log, ... my initial take is this way too complicated.
If you are going to submit a PR like this. Go through and squash the commits to something that can be reasonably be reviewed. We're not going to merge in 70+ "Phase 1a", "Phase 1b", ... commits right?
```
8d69d45d docs: Phase 1d mobile review — fix nav-mob occlusion of page footer
c4bb4b62 docs: Phase 1d styling pass — discipline blue, kill blanket p rule, lighten navbar
80e6d0aa docs: Phase 1c — connect/connection-pooling.md
1dc1f7e9 docs: Phase 1c — security/kerberos-gssapi.md
5e01a5b8 docs: Phase 1c — security/authentication.md
81b0cb19 docs: Phase 1c — connect/timeouts.md
cc2df3c4 docs: cross-link the two Security surfaces
7f0532ed docs: Phase 1c salvage — distribute use.md prose to topical pages
```
Take the time to consolidate things down to the point where they can be cherry picked and reviewed in chunks.
The new annotations are interesting. They could go in on there own. But there's even discussion there for why are we adding "INTERNAL" and "EXPERIMENTAL" if we're not using them (*I'm not sure we would ever use them*). I'm not sure we need the DEPRECATED either (we can read the `@Deprecated` to get the same information). And the `@PgPropertyType` may be better as part of the enum itself to enforce the data type contract as we could automate some of the property parsing / validation (e.g, reject negative seconds or invalid size descriptions).
If you are going to modify the site, switching out the generation or structure should be done entirely separate from switching out the verbiage. That way it's actually possible for someone to review them. Generational change that outputs the same content can be verified. And content changes that change meaning can be verified. But doing it all at once is impossible (and I'm not just going to delegate to an LLM to confirm it).
view thread (64+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #4075: docs: restructure site, compatibility page, changelog-driven releases
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox