pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: sehrope (@sehrope) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #4075: docs: restructure site, compatibility page, changelog-driven releases
Date: Fri, 22 May 2026 16:04:10 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

I'd strongly suggest we close this PR so that whatever is going to be reviewed stands on its own. The rest of the commentary in this thread is not relevant and would only be distracting.

I'd also suggest getting feedback and acceptance on new code additions (e.g., the enum stuff and it's code processor to generate docs) before going down a rabbit hole of building and running it. That way you don't feel like been a waste of time if the idea itself is shot down.

Finally, if you're going to present this as something for others to review, get rid of the sausage factory of LLM commits and structure it into logical chunks that you would expect from a human. I don't care if you use AI to write code. But I'm not going to step through 100+ "`phase 1a: refactor the flubber thingamabob`" with multi paragraph meaningless commit messages. You need to squash it down to something presentable before opening a PR. This dump everything on reviewers approach is not going to work.

view thread (64+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #4075: docs: restructure site, compatibility page, changelog-driven releases
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox