pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: [pgjdbc/pgjdbc] PR #4100: build: drop xgettext default keywords; regenerate translations
Date: Mon, 25 May 2026 13:26:40 +0000
Message-ID: <[email protected]> (raw)
`xgettext` in Java mode extracts strings from `getString()`, `gettext()` and similar by default in addition to user-defined keywords. The previous config added -kGT.tr but did not suppress the defaults, so column names passed to `rs.getString("oid")`, `rs.getString("proname")`, etc. ended up in `messages.pot` and were propagated into every `.po` file as non-translatable noise.
Adding an empty entry to keywords emits a bare `-k` before `-kGT.tr`, which clears `xgettext`'s default keyword list. Running `generateGettextSources` drops the spurious entries (oid, proname, typtype, proargtypes, adsrc, attidentity, attgenerated, rolname, relacl, attacl) from `messages.pot` and from every `.po`, and regenerates `messages_*.java`.
This is a purely mechanical commit, so there's nothing to review in there.
The offending non-translatable lines were like `msgid "oid"`
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #4100: build: drop xgettext default keywords; regenerate translations
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox