Message-ID: <gh-pgjdbc-pgjdbc-4114-c4553433588@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 27 May 2026 09:51:17 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #4114: fix: PGXAConnection no longer saves and restores the caller's autoCommit
In-Reply-To: <gh-pgjdbc-pgjdbc-4114@github.com>
References: <gh-pgjdbc-pgjdbc-4114@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 4553433588
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 4114
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/4114#issuecomment-4553433588
Content-Type: text/plain; charset=utf-8

Thanks @denis-anisimov for testing.

@davecramer the PR is ready: 38 tests green, resolves [#3123](https://github.com/pgjdbc/pgjdbc/issues/3123) and [#3153](https://github.com/pgjdbc/pgjdbc/issues/3153) (both from 2024), aligns the no-touch-autoCommit behaviour with Oracle / MSSQL / MySQL drivers.

One open question for you: the PR currently ships refreshed translations for all 16 message catalogues (machine-generated; only Russian was reviewed by hand). Two options:

a) Keep them as shipped. The catalogues stay in sync with the new English messages; any fuzzy entries can be refreshed by native speakers later.
b) Drop everything but Russian. Non-Russian users see English fallback for the new messages until a native speaker refreshes them.

I lean towards (a) but I'm fine with (b). Which do you prefer?