Message-ID: <gh-pgjdbc-pgjdbc-538-c3158544635@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 06 Aug 2025 09:20:36 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #538: Why getSchemaName return empty string or exists getBaseSchemaName and getColumnName return getColumnLabel?
In-Reply-To: <gh-pgjdbc-pgjdbc-538@github.com>
References: <gh-pgjdbc-pgjdbc-538@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 3158544635
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 538
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/538#issuecomment-3158544635
Content-Type: text/plain; charset=utf-8

> > One question though. Do we want to return public or just leave it empty ?
> 
> The `ResultSetMetaData::getSchemaName` Javadoc says _"name or "" if not applicable"_

The question is more about whether to add `public` since the original query did not have it and it's not necessary to create a query from it. Technically it is correct but seems odd to me. I would vote to return an empty string instead