Message-ID: <gh-pgjdbc-pgjdbc-879-c319855652@github.com>
From: "Frankqsy (@Frankqsy)" <noreply+Frankqsy@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 03 Aug 2017 03:07:51 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #879: loginTimeout in java.sql.DriverManager never be used
In-Reply-To: <gh-pgjdbc-pgjdbc-879@github.com>
References: <gh-pgjdbc-pgjdbc-879@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: Frankqsy
X-GitHub-Comment-Id: 319855652
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2017-08-03T03:12:13Z
X-GitHub-Issue: 879
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/879#issuecomment-319855652
Content-Type: text/plain; charset=utf-8

why don't you just set the default value to null, it's more easy. Just as follows:
```
LOGIN_TIMEOUT("loginTimeout", null,
      "Specify how long to wait for establishment of a database connection.");
```
I guess the original author has his concern to make the value precise to milliseconds.
So i suggest that you don't change its logical code.