Message-ID: <gh-pgjdbc-pgjdbc-879-c319867514@github.com>
From: "zemian (@zemian)" <noreply+zemian@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 03 Aug 2017 04:54:27 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #879: loginTimeout in java.sql.DriverManager never be used
In-Reply-To: <gh-pgjdbc-pgjdbc-879@github.com>
References: <gh-pgjdbc-pgjdbc-879@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: zemian
X-GitHub-Comment-Id: 319867514
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 879
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/879#issuecomment-319867514
Content-Type: text/plain; charset=utf-8

Because having NULL as default for int param seems odd.

If milliseconds were intented then it should take millis as long unit value Instead. I think it's odd to take float as parameter and call it secs.