Message-ID: <gh-pgjdbc-pgjdbc-879-c729753457@github.com>
From: "zemian (@zemian)" <noreply+zemian@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 18 Nov 2020 15:25:47 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #879: loginTimeout in java.sql.DriverManager never be used
In-Reply-To: <gh-pgjdbc-pgjdbc-879@github.com>
References: <gh-pgjdbc-pgjdbc-879@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: zemian
X-GitHub-Comment-Id: 729753457
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 879
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/879#issuecomment-729753457
Content-Type: text/plain; charset=utf-8

Hi Dave, I think I did address all the requests for changes. See all the
replies I made on the "Conversation" tab side. The last reply I made was
this: https://github.com/pgjdbc/pgjdbc/pull/900#issuecomment-341902369
regarding test assertion review comments. I thought I did my best and was
just waiting for approval. :)

I have now moved on to another project and I don't have much free time. So
if something quick, I will be happy to help, otherwise you guys might need
to pick up the rest of change.


On Tue, Nov 17, 2020 at 2:08 PM Dave Cramer <notifications@github.com>
wrote:

> @zemian <https://github.com/zemian> see
> https://github.com/pgjdbc/pgjdbc/pull/900/files for requests for changes
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pgjdbc/pgjdbc/issues/879#issuecomment-729139520>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFJ2JECY7CXFCW55B6352YLSQLC2DANCNFSM4DUB3BZQ>
> .
>