pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: tordmjohnson (@tordmjohnson) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #943: fix: synchronize modification of shared calendar (#921)
Date: Fri, 20 Oct 2017 13:49:13 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

> Would you please treat PgResultSet#getDefaultCalendar and PgPreparedStatement#getDefaultCalendar?

I'd be happy to, @vlsi, but I'm not sure I understand exactly what you're asking for.

Are you simply asking that `PgResultSet#getDefaultCalendar()` and `PgPreparedStatement#getDefaultCalendar()` synchronize over the monitor for modifying `TimestampUtils#calendarWithUserTz` (the `TimestampUtils` instance itself), since they may indirectly set the time zone on the shared calendar? That is, something like:

```
   private Calendar getDefaultCalendar() {
      TimestampUtils timestampUtils = connection.getTimestampUtils();
      synchronized (timestampUtils) {
         ...
      }
      ...
   }
```

view thread (29+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #943: fix: synchronize modification of shared calendar (#921)
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox