Message-ID: <gh-pgjdbc-pgjdbc-943-c338444571@github.com>
From: "tordmjohnson (@tordmjohnson)" <noreply+tordmjohnson@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sun, 22 Oct 2017 01:46:36 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #943: fix: synchronize modification of shared calendar (#921)
In-Reply-To: <gh-pgjdbc-pgjdbc-943@github.com>
References: <gh-pgjdbc-pgjdbc-943@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: tordmjohnson
X-GitHub-Comment-Id: 338444571
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 943
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/943#issuecomment-338444571
Content-Type: text/plain; charset=utf-8

OK, I've made `TimestampUtils#getSharedCalendar(TimeZone)` private, and pushed all the dependent code from `PgResultSet` and `PgPreparedStatement` down into `TimestampUtils`. This was an initial, more-or-less straight forward transformation, and could probably use some refactoring, but didn't want to mix objectives with this initial set of changes.

For example, it seems unnecessary to keep a second cached `defaultTimeZone` in `TimestampUtils`, but it wasn't exactly clear to me why it was being cleared after some calls, such as from `PgPreparedStatement#executeBatch()`.

Would you like me to continue, to go on and refactor a bit, such as removing the seemingly redundant `TimestampUtils.defaultTimeZone`? Or should I just stop here? Thanks for any guidance.