agora inbox for pgpool-committers@postgresql.orghelp / color / mirror / Atom feed
pgpool: Fix broken scram-sha-256 authentication on big-endian machies. 6+ messages / 1 participants [nested] [flat]
* pgpool: Fix broken scram-sha-256 authentication on big-endian machies. @ 2025-06-30 02:58 Bo Peng <pengbo@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Bo Peng @ 2025-06-30 02:58 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix broken scram-sha-256 authentication on big-endian machies. When scram-sha-256 authentication is performed, a hash function pg_sha_256_final is used. It was imported from PostgreSQL and it uses preprocessor define WORDS_BIGENDIAN to judge host machine's endianness. Although WORDS_BIGENDIAN should be defined while configure, this part was missed when pg_sha_256_final (and others) was imported from PostgreSQL. As a result, scram-sha-256 worked only in little endian machines. This commit fixes the issue by adding AC_C_BIGENDIAN macro to configure.ac. Author: Tatsuo Ishii Reported-by: Christoph Berg Reviewed-by: pranavkaruvally Discussion: https://github.com/pgpool/pgpool2/issues/106 Backpatch-through: v4.2 Branch ------ V4_4_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=06a3dda48c29d1b57b1acead5029469c1fdbc... Modified Files -------------- configure | 224 ++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 2 +- src/include/config.h.in | 15 ++++ 3 files changed, 240 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix broken scram-sha-256 authentication on big-endian machies. @ 2025-06-30 03:00 Bo Peng <pengbo@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Bo Peng @ 2025-06-30 03:00 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix broken scram-sha-256 authentication on big-endian machies. When scram-sha-256 authentication is performed, a hash function pg_sha_256_final is used. It was imported from PostgreSQL and it uses preprocessor define WORDS_BIGENDIAN to judge host machine's endianness. Although WORDS_BIGENDIAN should be defined while configure, this part was missed when pg_sha_256_final (and others) was imported from PostgreSQL. As a result, scram-sha-256 worked only in little endian machines. This commit fixes the issue by adding AC_C_BIGENDIAN macro to configure.ac. Author: Tatsuo Ishii Reported-by: Christoph Berg Reviewed-by: pranavkaruvally Discussion: https://github.com/pgpool/pgpool2/issues/106 Backpatch-through: v4.2 Branch ------ V4_3_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=fa7761b3a088acbc20cabf82519fe6de8abc9... Modified Files -------------- configure | 224 ++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 2 +- src/include/config.h.in | 15 ++++ 3 files changed, 240 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix broken scram-sha-256 authentication on big-endian machies. @ 2025-06-30 03:01 Bo Peng <pengbo@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Bo Peng @ 2025-06-30 03:01 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix broken scram-sha-256 authentication on big-endian machies. When scram-sha-256 authentication is performed, a hash function pg_sha_256_final is used. It was imported from PostgreSQL and it uses preprocessor define WORDS_BIGENDIAN to judge host machine's endianness. Although WORDS_BIGENDIAN should be defined while configure, this part was missed when pg_sha_256_final (and others) was imported from PostgreSQL. As a result, scram-sha-256 worked only in little endian machines. This commit fixes the issue by adding AC_C_BIGENDIAN macro to configure.ac. Author: Tatsuo Ishii Reported-by: Christoph Berg Reviewed-by: pranavkaruvally Discussion: https://github.com/pgpool/pgpool2/issues/106 Backpatch-through: v4.2 Branch ------ V4_2_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=85dedc8269da0a0053b4ae485533463097e39... Modified Files -------------- configure | 224 ++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 2 +- src/include/config.h.in | 15 ++++ 3 files changed, 240 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix broken scram-sha-256 authentication on big-endian machies. @ 2025-06-30 03:02 Bo Peng <pengbo@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Bo Peng @ 2025-06-30 03:02 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix broken scram-sha-256 authentication on big-endian machies. When scram-sha-256 authentication is performed, a hash function pg_sha_256_final is used. It was imported from PostgreSQL and it uses preprocessor define WORDS_BIGENDIAN to judge host machine's endianness. Although WORDS_BIGENDIAN should be defined while configure, this part was missed when pg_sha_256_final (and others) was imported from PostgreSQL. As a result, scram-sha-256 worked only in little endian machines. This commit fixes the issue by adding AC_C_BIGENDIAN macro to configure.ac. Author: Tatsuo Ishii Reported-by: Christoph Berg Reviewed-by: pranavkaruvally Discussion: https://github.com/pgpool/pgpool2/issues/106 Backpatch-through: v4.2 Branch ------ V4_5_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=88cef7cc3b6b7dcfa07b49b913f585ef4ab05... Modified Files -------------- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix broken scram-sha-256 authentication on big-endian machies. @ 2025-06-30 03:03 Bo Peng <pengbo@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Bo Peng @ 2025-06-30 03:03 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix broken scram-sha-256 authentication on big-endian machies. When scram-sha-256 authentication is performed, a hash function pg_sha_256_final is used. It was imported from PostgreSQL and it uses preprocessor define WORDS_BIGENDIAN to judge host machine's endianness. Although WORDS_BIGENDIAN should be defined while configure, this part was missed when pg_sha_256_final (and others) was imported from PostgreSQL. As a result, scram-sha-256 worked only in little endian machines. This commit fixes the issue by adding AC_C_BIGENDIAN macro to configure.ac. Author: Tatsuo Ishii Reported-by: Christoph Berg Reviewed-by: pranavkaruvally Discussion: https://github.com/pgpool/pgpool2/issues/106 Backpatch-through: v4.2 Branch ------ V4_6_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=bac455b2f510ad90bd35df0a98f6bfdf70d2c... Modified Files -------------- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix broken scram-sha-256 authentication on big-endian machies. @ 2025-06-30 03:03 Bo Peng <pengbo@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Bo Peng @ 2025-06-30 03:03 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix broken scram-sha-256 authentication on big-endian machies. When scram-sha-256 authentication is performed, a hash function pg_sha_256_final is used. It was imported from PostgreSQL and it uses preprocessor define WORDS_BIGENDIAN to judge host machine's endianness. Although WORDS_BIGENDIAN should be defined while configure, this part was missed when pg_sha_256_final (and others) was imported from PostgreSQL. As a result, scram-sha-256 worked only in little endian machines. This commit fixes the issue by adding AC_C_BIGENDIAN macro to configure.ac. Author: Tatsuo Ishii Reported-by: Christoph Berg Reviewed-by: pranavkaruvally Discussion: https://github.com/pgpool/pgpool2/issues/106 Backpatch-through: v4.2 Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=864a1fe114a6af283804f1c3e231ed697a0a8... Modified Files -------------- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-06-30 03:03 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-06-30 02:58 pgpool: Fix broken scram-sha-256 authentication on big-endian machies. Bo Peng <pengbo@sraoss.co.jp> 2025-06-30 03:00 pgpool: Fix broken scram-sha-256 authentication on big-endian machies. Bo Peng <pengbo@sraoss.co.jp> 2025-06-30 03:01 pgpool: Fix broken scram-sha-256 authentication on big-endian machies. Bo Peng <pengbo@sraoss.co.jp> 2025-06-30 03:02 pgpool: Fix broken scram-sha-256 authentication on big-endian machies. Bo Peng <pengbo@sraoss.co.jp> 2025-06-30 03:03 pgpool: Fix broken scram-sha-256 authentication on big-endian machies. Bo Peng <pengbo@sraoss.co.jp> 2025-06-30 03:03 pgpool: Fix broken scram-sha-256 authentication on big-endian machies. Bo Peng <pengbo@sraoss.co.jp>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox