agora inbox for pgpool-committers@postgresql.orghelp / color / mirror / Atom feed
pgpool: Fix watchdog to print inappropriate NOTICE message. 6+ messages / 1 participants [nested] [flat]
* pgpool: Fix watchdog to print inappropriate NOTICE message. @ 2025-07-25 05:07 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-07-25 05:07 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix watchdog to print inappropriate NOTICE message. read_ipc_socket_and_process() printed a notice message every time when it wrote commands to IPC socket even if it was successful. Fix this to print the notice message only when the write failed. The reason why this bug was not recognized is, the message appears only when log_min_messages is set to notice or higher. Discussion: https://github.com/pgpool/pgpool2/issues/121 Backpatch-through: v4.2 Branch ------ V4_2_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=688f5b9d411c012ed0b77c36bc28d9b8f07c9... Modified Files -------------- src/watchdog/watchdog.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix watchdog to print inappropriate NOTICE message. @ 2025-07-25 05:07 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-07-25 05:07 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix watchdog to print inappropriate NOTICE message. read_ipc_socket_and_process() printed a notice message every time when it wrote commands to IPC socket even if it was successful. Fix this to print the notice message only when the write failed. The reason why this bug was not recognized is, the message appears only when log_min_messages is set to notice or higher. Discussion: https://github.com/pgpool/pgpool2/issues/121 Backpatch-through: v4.2 Branch ------ V4_3_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=6d5bad228d2d466cd2f0cd7240edb063ddd18... Modified Files -------------- src/watchdog/watchdog.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix watchdog to print inappropriate NOTICE message. @ 2025-07-25 05:07 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-07-25 05:07 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix watchdog to print inappropriate NOTICE message. read_ipc_socket_and_process() printed a notice message every time when it wrote commands to IPC socket even if it was successful. Fix this to print the notice message only when the write failed. The reason why this bug was not recognized is, the message appears only when log_min_messages is set to notice or higher. Discussion: https://github.com/pgpool/pgpool2/issues/121 Backpatch-through: v4.2 Branch ------ V4_4_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=8312863ae89e2a77bbb519292cb84f6eee003... Modified Files -------------- src/watchdog/watchdog.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix watchdog to print inappropriate NOTICE message. @ 2025-07-25 05:07 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-07-25 05:07 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix watchdog to print inappropriate NOTICE message. read_ipc_socket_and_process() printed a notice message every time when it wrote commands to IPC socket even if it was successful. Fix this to print the notice message only when the write failed. The reason why this bug was not recognized is, the message appears only when log_min_messages is set to notice or higher. Discussion: https://github.com/pgpool/pgpool2/issues/121 Backpatch-through: v4.2 Branch ------ V4_5_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=65b877dd99c4e79b31a21d0d6cc11d095755c... Modified Files -------------- src/watchdog/watchdog.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix watchdog to print inappropriate NOTICE message. @ 2025-07-25 05:07 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-07-25 05:07 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix watchdog to print inappropriate NOTICE message. read_ipc_socket_and_process() printed a notice message every time when it wrote commands to IPC socket even if it was successful. Fix this to print the notice message only when the write failed. The reason why this bug was not recognized is, the message appears only when log_min_messages is set to notice or higher. Discussion: https://github.com/pgpool/pgpool2/issues/121 Backpatch-through: v4.2 Branch ------ V4_6_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=75d905ff91f6badca30c22bf31a51a69bf9c6... Modified Files -------------- src/watchdog/watchdog.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix watchdog to print inappropriate NOTICE message. @ 2025-07-25 05:07 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-07-25 05:07 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix watchdog to print inappropriate NOTICE message. read_ipc_socket_and_process() printed a notice message every time when it wrote commands to IPC socket even if it was successful. Fix this to print the notice message only when the write failed. The reason why this bug was not recognized is, the message appears only when log_min_messages is set to notice or higher. Discussion: https://github.com/pgpool/pgpool2/issues/121 Backpatch-through: v4.2 Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=8c6a4f6beb62e6f88829108e06684aae25fb4... Modified Files -------------- src/watchdog/watchdog.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-07-25 05:07 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-07-25 05:07 pgpool: Fix watchdog to print inappropriate NOTICE message. Tatsuo Ishii <ishii@postgresql.org> 2025-07-25 05:07 pgpool: Fix watchdog to print inappropriate NOTICE message. Tatsuo Ishii <ishii@postgresql.org> 2025-07-25 05:07 pgpool: Fix watchdog to print inappropriate NOTICE message. Tatsuo Ishii <ishii@postgresql.org> 2025-07-25 05:07 pgpool: Fix watchdog to print inappropriate NOTICE message. Tatsuo Ishii <ishii@postgresql.org> 2025-07-25 05:07 pgpool: Fix watchdog to print inappropriate NOTICE message. Tatsuo Ishii <ishii@postgresql.org> 2025-07-25 05:07 pgpool: Fix watchdog to print inappropriate NOTICE message. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox