agora inbox for pgpool-committers@postgresql.orghelp / color / mirror / Atom feed
pgpool: Fix compiling issue on 32-bit environments. 6+ messages / 1 participants [nested] [flat]
* pgpool: Fix compiling issue on 32-bit environments. @ 2025-09-17 23:51 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-09-17 23:51 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix compiling issue on 32-bit environments. It is reported that compiling src/parser/snprintf.c on 32-bit environments fails due to undefined functions (isnan() and ininf()). They come from math.h so include it. snprintf.c was imported from PostgreSQL long time ago. If we look into the original file (src/port/snprintf.c) it actually has "#include <math.h>" already. Including math.h was provided as a pull request: https://github.com/pgpool/pgpool2/pull/128 I also added a minor modification to the patch to reorder the positions of include files. Author: Gyorgy Sarvari <skandigraun@gmail.com> Discussion: https://www.postgresql.org/message-id/20250917.194736.353755422175293639.ishii%40postgresql.org Backpatch-through: v4.2 Branch ------ V4_2_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=4c6f25f3ea2c1f373191c631ac7358db6c2cb... Modified Files -------------- src/parser/snprintf.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix compiling issue on 32-bit environments. @ 2025-09-17 23:51 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-09-17 23:51 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix compiling issue on 32-bit environments. It is reported that compiling src/parser/snprintf.c on 32-bit environments fails due to undefined functions (isnan() and ininf()). They come from math.h so include it. snprintf.c was imported from PostgreSQL long time ago. If we look into the original file (src/port/snprintf.c) it actually has "#include <math.h>" already. Including math.h was provided as a pull request: https://github.com/pgpool/pgpool2/pull/128 I also added a minor modification to the patch to reorder the positions of include files. Author: Gyorgy Sarvari <skandigraun@gmail.com> Discussion: https://www.postgresql.org/message-id/20250917.194736.353755422175293639.ishii%40postgresql.org Backpatch-through: v4.2 Branch ------ V4_3_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=485921baa9680fc35fe3449d0fbbc5537f861... Modified Files -------------- src/parser/snprintf.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix compiling issue on 32-bit environments. @ 2025-09-17 23:51 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-09-17 23:51 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix compiling issue on 32-bit environments. It is reported that compiling src/parser/snprintf.c on 32-bit environments fails due to undefined functions (isnan() and ininf()). They come from math.h so include it. snprintf.c was imported from PostgreSQL long time ago. If we look into the original file (src/port/snprintf.c) it actually has "#include <math.h>" already. Including math.h was provided as a pull request: https://github.com/pgpool/pgpool2/pull/128 I also added a minor modification to the patch to reorder the positions of include files. Author: Gyorgy Sarvari <skandigraun@gmail.com> Discussion: https://www.postgresql.org/message-id/20250917.194736.353755422175293639.ishii%40postgresql.org Backpatch-through: v4.2 Branch ------ V4_4_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=7731e800c41f3f0e2e4162656031e857706d7... Modified Files -------------- src/parser/snprintf.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix compiling issue on 32-bit environments. @ 2025-09-17 23:51 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-09-17 23:51 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix compiling issue on 32-bit environments. It is reported that compiling src/parser/snprintf.c on 32-bit environments fails due to undefined functions (isnan() and ininf()). They come from math.h so include it. snprintf.c was imported from PostgreSQL long time ago. If we look into the original file (src/port/snprintf.c) it actually has "#include <math.h>" already. Including math.h was provided as a pull request: https://github.com/pgpool/pgpool2/pull/128 I also added a minor modification to the patch to reorder the positions of include files. Author: Gyorgy Sarvari <skandigraun@gmail.com> Discussion: https://www.postgresql.org/message-id/20250917.194736.353755422175293639.ishii%40postgresql.org Backpatch-through: v4.2 Branch ------ V4_5_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=e0383935d573ae2b292efff20dd85c0f37523... Modified Files -------------- src/parser/snprintf.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix compiling issue on 32-bit environments. @ 2025-09-17 23:51 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-09-17 23:51 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix compiling issue on 32-bit environments. It is reported that compiling src/parser/snprintf.c on 32-bit environments fails due to undefined functions (isnan() and ininf()). They come from math.h so include it. snprintf.c was imported from PostgreSQL long time ago. If we look into the original file (src/port/snprintf.c) it actually has "#include <math.h>" already. Including math.h was provided as a pull request: https://github.com/pgpool/pgpool2/pull/128 I also added a minor modification to the patch to reorder the positions of include files. Author: Gyorgy Sarvari <skandigraun@gmail.com> Discussion: https://www.postgresql.org/message-id/20250917.194736.353755422175293639.ishii%40postgresql.org Backpatch-through: v4.2 Branch ------ V4_6_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=f20f7041cf4bd2847e1f82d52a0505a9c72f1... Modified Files -------------- src/parser/snprintf.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix compiling issue on 32-bit environments. @ 2025-09-17 23:51 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-09-17 23:51 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix compiling issue on 32-bit environments. It is reported that compiling src/parser/snprintf.c on 32-bit environments fails due to undefined functions (isnan() and ininf()). They come from math.h so include it. snprintf.c was imported from PostgreSQL long time ago. If we look into the original file (src/port/snprintf.c) it actually has "#include <math.h>" already. Including math.h was provided as a pull request: https://github.com/pgpool/pgpool2/pull/128 I also added a minor modification to the patch to reorder the positions of include files. Author: Gyorgy Sarvari <skandigraun@gmail.com> Discussion: https://www.postgresql.org/message-id/20250917.194736.353755422175293639.ishii%40postgresql.org Backpatch-through: v4.2 Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=574e3e4d270ae9488ab06fe333d3fbd014bcf... Modified Files -------------- src/parser/snprintf.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-09-17 23:51 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-09-17 23:51 pgpool: Fix compiling issue on 32-bit environments. Tatsuo Ishii <ishii@postgresql.org> 2025-09-17 23:51 pgpool: Fix compiling issue on 32-bit environments. Tatsuo Ishii <ishii@postgresql.org> 2025-09-17 23:51 pgpool: Fix compiling issue on 32-bit environments. Tatsuo Ishii <ishii@postgresql.org> 2025-09-17 23:51 pgpool: Fix compiling issue on 32-bit environments. Tatsuo Ishii <ishii@postgresql.org> 2025-09-17 23:51 pgpool: Fix compiling issue on 32-bit environments. Tatsuo Ishii <ishii@postgresql.org> 2025-09-17 23:51 pgpool: Fix compiling issue on 32-bit environments. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox