agora inbox for pgpool-committers@postgresql.org
help / color / mirror / Atom feedpgpool: Fix pg_enc not working if both -p and -P are provided.
6+ messages / 1 participants
[nested] [flat]
* pgpool: Fix pg_enc not working if both -p and -P are provided.
@ 2025-09-24 01:43 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2025-09-24 01:43 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix pg_enc not working if both -p and -P are provided.
In the original report (https://github.com/pgpool/pgpool2/issues/129:
[root@test1 bin]# ./pg_enc -p -P
db password:
encryption key:
encryption key not provided
Also I found a misleading comment:
case 'p': /* prompt for postgres password */
This is not appropriate since the password is not provided to
PostgreSQL. It is totally unrelated to the issue but I replaced it
with following in this opportunity:
case 'p': /* prompt for password to be encrypted */
Author: jinyang liu <liujy@highgo.com>
Discussion: https://www.postgresql.org/message-id/7f18c30b.237.1997555ca11.Coremail.liujy%40highgo.com
Backpatch-through: v4.2
Branch
------
V4_2_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=11a2fe02012c8c0056cd75850518f9e315d3a...
Modified Files
--------------
src/tools/pgenc/pg_enc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pg_enc not working if both -p and -P are provided.
@ 2025-09-24 01:44 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2025-09-24 01:44 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix pg_enc not working if both -p and -P are provided.
In the original report (https://github.com/pgpool/pgpool2/issues/129:
[root@test1 bin]# ./pg_enc -p -P
db password:
encryption key:
encryption key not provided
Also I found a misleading comment:
case 'p': /* prompt for postgres password */
This is not appropriate since the password is not provided to
PostgreSQL. It is totally unrelated to the issue but I replaced it
with following in this opportunity:
case 'p': /* prompt for password to be encrypted */
Author: jinyang liu <liujy@highgo.com>
Discussion: https://www.postgresql.org/message-id/7f18c30b.237.1997555ca11.Coremail.liujy%40highgo.com
Backpatch-through: v4.2
Branch
------
V4_3_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=51f20fbad3c4ef4c1143a0325bb8792eb7f86...
Modified Files
--------------
src/tools/pgenc/pg_enc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pg_enc not working if both -p and -P are provided.
@ 2025-09-24 01:44 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2025-09-24 01:44 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix pg_enc not working if both -p and -P are provided.
In the original report (https://github.com/pgpool/pgpool2/issues/129:
[root@test1 bin]# ./pg_enc -p -P
db password:
encryption key:
encryption key not provided
Also I found a misleading comment:
case 'p': /* prompt for postgres password */
This is not appropriate since the password is not provided to
PostgreSQL. It is totally unrelated to the issue but I replaced it
with following in this opportunity:
case 'p': /* prompt for password to be encrypted */
Author: jinyang liu <liujy@highgo.com>
Discussion: https://www.postgresql.org/message-id/7f18c30b.237.1997555ca11.Coremail.liujy%40highgo.com
Backpatch-through: v4.2
Branch
------
V4_4_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=be197c5c518ddb5c48e2d08536ae09b7c2472...
Modified Files
--------------
src/tools/pgenc/pg_enc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pg_enc not working if both -p and -P are provided.
@ 2025-09-24 01:44 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2025-09-24 01:44 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix pg_enc not working if both -p and -P are provided.
In the original report (https://github.com/pgpool/pgpool2/issues/129:
[root@test1 bin]# ./pg_enc -p -P
db password:
encryption key:
encryption key not provided
Also I found a misleading comment:
case 'p': /* prompt for postgres password */
This is not appropriate since the password is not provided to
PostgreSQL. It is totally unrelated to the issue but I replaced it
with following in this opportunity:
case 'p': /* prompt for password to be encrypted */
Author: jinyang liu <liujy@highgo.com>
Discussion: https://www.postgresql.org/message-id/7f18c30b.237.1997555ca11.Coremail.liujy%40highgo.com
Backpatch-through: v4.2
Branch
------
V4_5_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=8df0489301f16040996353ed21fc9cf7a7a12...
Modified Files
--------------
src/tools/pgenc/pg_enc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pg_enc not working if both -p and -P are provided.
@ 2025-09-24 01:44 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2025-09-24 01:44 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix pg_enc not working if both -p and -P are provided.
In the original report (https://github.com/pgpool/pgpool2/issues/129:
[root@test1 bin]# ./pg_enc -p -P
db password:
encryption key:
encryption key not provided
Also I found a misleading comment:
case 'p': /* prompt for postgres password */
This is not appropriate since the password is not provided to
PostgreSQL. It is totally unrelated to the issue but I replaced it
with following in this opportunity:
case 'p': /* prompt for password to be encrypted */
Author: jinyang liu <liujy@highgo.com>
Discussion: https://www.postgresql.org/message-id/7f18c30b.237.1997555ca11.Coremail.liujy%40highgo.com
Backpatch-through: v4.2
Branch
------
V4_6_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=59a359eef24c73e03c894eae7598949d396da...
Modified Files
--------------
src/tools/pgenc/pg_enc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pg_enc not working if both -p and -P are provided.
@ 2025-09-24 01:44 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2025-09-24 01:44 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix pg_enc not working if both -p and -P are provided.
In the original report (https://github.com/pgpool/pgpool2/issues/129:
[root@test1 bin]# ./pg_enc -p -P
db password:
encryption key:
encryption key not provided
Also I found a misleading comment:
case 'p': /* prompt for postgres password */
This is not appropriate since the password is not provided to
PostgreSQL. It is totally unrelated to the issue but I replaced it
with following in this opportunity:
case 'p': /* prompt for password to be encrypted */
Author: jinyang liu <liujy@highgo.com>
Discussion: https://www.postgresql.org/message-id/7f18c30b.237.1997555ca11.Coremail.liujy%40highgo.com
Backpatch-through: v4.2
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=6635270c93d80fd4b3d904242116379a4c8e4...
Modified Files
--------------
src/tools/pgenc/pg_enc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-09-24 01:44 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-09-24 01:43 pgpool: Fix pg_enc not working if both -p and -P are provided. Tatsuo Ishii <ishii@postgresql.org>
2025-09-24 01:44 pgpool: Fix pg_enc not working if both -p and -P are provided. Tatsuo Ishii <ishii@postgresql.org>
2025-09-24 01:44 pgpool: Fix pg_enc not working if both -p and -P are provided. Tatsuo Ishii <ishii@postgresql.org>
2025-09-24 01:44 pgpool: Fix pg_enc not working if both -p and -P are provided. Tatsuo Ishii <ishii@postgresql.org>
2025-09-24 01:44 pgpool: Fix pg_enc not working if both -p and -P are provided. Tatsuo Ishii <ishii@postgresql.org>
2025-09-24 01:44 pgpool: Fix pg_enc not working if both -p and -P are provided. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox