agora inbox for pgpool-committers@postgresql.orghelp / color / mirror / Atom feed
pgpool: Remove unnecessary application_name treatment. 6+ messages / 1 participants [nested] [flat]
* pgpool: Remove unnecessary application_name treatment. @ 2025-11-07 09:36 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-11-07 09:36 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Remove unnecessary application_name treatment. Commit c20858797eafe377b30166b467d2a36de89768e1 added an treatment to send "set application_name" command to backend when reusing existing connection. The reason were: (1) to set application_name parameter to proper value, which is the value specified in the startup packet when the connection was created. (2) to return application_name parameter status message to frontend. However, (1) is not necessary, because when the previous connection is closed, queries in reset_query_list are executed and the list usually includes "DISCARD ALL", which reset the application_name value to the previous one which was set when the connection was established. Also (2) is not necessary either, because send_params() sends all necessary parameter status messages to frontend including application_name. For these reasons, I think the treatment added in c20858797eafe377b30166b467d2a36de89768e1 is not necessary. This commit just removes the treatment. Also this will enhance the performance when some of backend nodes are in geographically distant location, by eliminating the time to send application_name to such a node and wait for the response. Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/130 Backpatch-through: v4.2. Branch ------ V4_2_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=f122a13b79f8cd1c3146d6a0189fd5e825c54... Modified Files -------------- src/protocol/child.c | 30 +----------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Remove unnecessary application_name treatment. @ 2025-11-07 09:36 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-11-07 09:36 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Remove unnecessary application_name treatment. Commit c20858797eafe377b30166b467d2a36de89768e1 added an treatment to send "set application_name" command to backend when reusing existing connection. The reason were: (1) to set application_name parameter to proper value, which is the value specified in the startup packet when the connection was created. (2) to return application_name parameter status message to frontend. However, (1) is not necessary, because when the previous connection is closed, queries in reset_query_list are executed and the list usually includes "DISCARD ALL", which reset the application_name value to the previous one which was set when the connection was established. Also (2) is not necessary either, because send_params() sends all necessary parameter status messages to frontend including application_name. For these reasons, I think the treatment added in c20858797eafe377b30166b467d2a36de89768e1 is not necessary. This commit just removes the treatment. Also this will enhance the performance when some of backend nodes are in geographically distant location, by eliminating the time to send application_name to such a node and wait for the response. Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/130 Backpatch-through: v4.2. Branch ------ V4_3_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=920cc0439d7c9d793d5a39b2e3e9836cc6a85... Modified Files -------------- src/protocol/child.c | 30 +----------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Remove unnecessary application_name treatment. @ 2025-11-07 09:37 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-11-07 09:37 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Remove unnecessary application_name treatment. Commit c20858797eafe377b30166b467d2a36de89768e1 added an treatment to send "set application_name" command to backend when reusing existing connection. The reason were: (1) to set application_name parameter to proper value, which is the value specified in the startup packet when the connection was created. (2) to return application_name parameter status message to frontend. However, (1) is not necessary, because when the previous connection is closed, queries in reset_query_list are executed and the list usually includes "DISCARD ALL", which reset the application_name value to the previous one which was set when the connection was established. Also (2) is not necessary either, because send_params() sends all necessary parameter status messages to frontend including application_name. For these reasons, I think the treatment added in c20858797eafe377b30166b467d2a36de89768e1 is not necessary. This commit just removes the treatment. Also this will enhance the performance when some of backend nodes are in geographically distant location, by eliminating the time to send application_name to such a node and wait for the response. Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/130 Backpatch-through: v4.2. Branch ------ V4_4_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=0faceca300774bb25a8ff7a9eab67753f6a3f... Modified Files -------------- src/protocol/child.c | 30 +----------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Remove unnecessary application_name treatment. @ 2025-11-07 09:37 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-11-07 09:37 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Remove unnecessary application_name treatment. Commit c20858797eafe377b30166b467d2a36de89768e1 added an treatment to send "set application_name" command to backend when reusing existing connection. The reason were: (1) to set application_name parameter to proper value, which is the value specified in the startup packet when the connection was created. (2) to return application_name parameter status message to frontend. However, (1) is not necessary, because when the previous connection is closed, queries in reset_query_list are executed and the list usually includes "DISCARD ALL", which reset the application_name value to the previous one which was set when the connection was established. Also (2) is not necessary either, because send_params() sends all necessary parameter status messages to frontend including application_name. For these reasons, I think the treatment added in c20858797eafe377b30166b467d2a36de89768e1 is not necessary. This commit just removes the treatment. Also this will enhance the performance when some of backend nodes are in geographically distant location, by eliminating the time to send application_name to such a node and wait for the response. Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/130 Backpatch-through: v4.2. Branch ------ V4_5_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=1ecd9fc91cfeee4c7fe085aa36cefb5cee729... Modified Files -------------- src/protocol/child.c | 44 +------------------------------------------- 1 file changed, 1 insertion(+), 43 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Remove unnecessary application_name treatment. @ 2025-11-07 09:37 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-11-07 09:37 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Remove unnecessary application_name treatment. Commit c20858797eafe377b30166b467d2a36de89768e1 added an treatment to send "set application_name" command to backend when reusing existing connection. The reason were: (1) to set application_name parameter to proper value, which is the value specified in the startup packet when the connection was created. (2) to return application_name parameter status message to frontend. However, (1) is not necessary, because when the previous connection is closed, queries in reset_query_list are executed and the list usually includes "DISCARD ALL", which reset the application_name value to the previous one which was set when the connection was established. Also (2) is not necessary either, because send_params() sends all necessary parameter status messages to frontend including application_name. For these reasons, I think the treatment added in c20858797eafe377b30166b467d2a36de89768e1 is not necessary. This commit just removes the treatment. Also this will enhance the performance when some of backend nodes are in geographically distant location, by eliminating the time to send application_name to such a node and wait for the response. Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/130 Backpatch-through: v4.2. Branch ------ V4_6_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=4fabca331b48e6b0d26d24267b9d63577ce06... Modified Files -------------- src/protocol/child.c | 44 +------------------------------------------- 1 file changed, 1 insertion(+), 43 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Remove unnecessary application_name treatment. @ 2025-11-07 09:37 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2025-11-07 09:37 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Remove unnecessary application_name treatment. Commit c20858797eafe377b30166b467d2a36de89768e1 added an treatment to send "set application_name" command to backend when reusing existing connection. The reason were: (1) to set application_name parameter to proper value, which is the value specified in the startup packet when the connection was created. (2) to return application_name parameter status message to frontend. However, (1) is not necessary, because when the previous connection is closed, queries in reset_query_list are executed and the list usually includes "DISCARD ALL", which reset the application_name value to the previous one which was set when the connection was established. Also (2) is not necessary either, because send_params() sends all necessary parameter status messages to frontend including application_name. For these reasons, I think the treatment added in c20858797eafe377b30166b467d2a36de89768e1 is not necessary. This commit just removes the treatment. Also this will enhance the performance when some of backend nodes are in geographically distant location, by eliminating the time to send application_name to such a node and wait for the response. Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/130 Backpatch-through: v4.2. Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=22b8179e6e7261005d8e2f3125f8de75aa927... Modified Files -------------- src/protocol/child.c | 45 +-------------------------------------------- 1 file changed, 1 insertion(+), 44 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-11-07 09:37 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-11-07 09:36 pgpool: Remove unnecessary application_name treatment. Tatsuo Ishii <ishii@postgresql.org> 2025-11-07 09:36 pgpool: Remove unnecessary application_name treatment. Tatsuo Ishii <ishii@postgresql.org> 2025-11-07 09:37 pgpool: Remove unnecessary application_name treatment. Tatsuo Ishii <ishii@postgresql.org> 2025-11-07 09:37 pgpool: Remove unnecessary application_name treatment. Tatsuo Ishii <ishii@postgresql.org> 2025-11-07 09:37 pgpool: Remove unnecessary application_name treatment. Tatsuo Ishii <ishii@postgresql.org> 2025-11-07 09:37 pgpool: Remove unnecessary application_name treatment. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox