agora inbox for pgpool-committers@postgresql.org  
help / color / mirror / Atom feed
pgpool: Test: fix occasional failure of 034.promote_node.
6+ messages / 1 participants
[nested] [flat]

* pgpool: Test: fix occasional failure of 034.promote_node.
@ 2025-12-17 09:06 Tatsuo Ishii <ishii@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Tatsuo Ishii @ 2025-12-17 09:06 UTC (permalink / raw)
  To: pgpool-committers@lists.postgresql.org

Test: fix occasional failure of 034.promote_node.

The error is caused by follow primary process. In the process
pg_rewind is executed to sync a standby with new primary. If new
primary promotion is slow, pg_rewind incorrectly returns "there's no
need to pg_rewind". Even if new standby starts, the standby causes an
error later on which make the 034.promote_node test failed.

To fix this, add CHECKPOINT in the failover script. Also add "-c"
option pg_rewind to retrieve WAL from archives so that pg_rewind could
find necessary WAL.

Reported-by: Bo Peng <pengbo@sraoss.co.jp>
Suggested-by: Bo Peng <pengbo@sraoss.co.jp>
Backpatch-through: v4.3

Branch
------
V4_3_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=55eb137c13a737ae7b250246b4292d8778fe2...

Modified Files
--------------
src/test/pgpool_setup.in | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgpool: Test: fix occasional failure of 034.promote_node.
@ 2025-12-17 09:07 Tatsuo Ishii <ishii@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Tatsuo Ishii @ 2025-12-17 09:07 UTC (permalink / raw)
  To: pgpool-committers@lists.postgresql.org

Test: fix occasional failure of 034.promote_node.

The error is caused by follow primary process. In the process
pg_rewind is executed to sync a standby with new primary. If new
primary promotion is slow, pg_rewind incorrectly returns "there's no
need to pg_rewind". Even if new standby starts, the standby causes an
error later on which make the 034.promote_node test failed.

To fix this, add CHECKPOINT in the failover script. Also add "-c"
option pg_rewind to retrieve WAL from archives so that pg_rewind could
find necessary WAL.

Reported-by: Bo Peng <pengbo@sraoss.co.jp>
Suggested-by: Bo Peng <pengbo@sraoss.co.jp>
Backpatch-through: v4.3

Branch
------
V4_4_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=ef783a03bc4ad02a81e18f1f726613b367af1...

Modified Files
--------------
src/test/pgpool_setup.in | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgpool: Test: fix occasional failure of 034.promote_node.
@ 2025-12-17 09:07 Tatsuo Ishii <ishii@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Tatsuo Ishii @ 2025-12-17 09:07 UTC (permalink / raw)
  To: pgpool-committers@lists.postgresql.org

Test: fix occasional failure of 034.promote_node.

The error is caused by follow primary process. In the process
pg_rewind is executed to sync a standby with new primary. If new
primary promotion is slow, pg_rewind incorrectly returns "there's no
need to pg_rewind". Even if new standby starts, the standby causes an
error later on which make the 034.promote_node test failed.

To fix this, add CHECKPOINT in the failover script. Also add "-c"
option pg_rewind to retrieve WAL from archives so that pg_rewind could
find necessary WAL.

Reported-by: Bo Peng <pengbo@sraoss.co.jp>
Suggested-by: Bo Peng <pengbo@sraoss.co.jp>
Backpatch-through: v4.3

Branch
------
V4_5_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=ebff5ca1d0572fe714abc321cabae97878694...

Modified Files
--------------
src/test/pgpool_setup.in | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgpool: Test: fix occasional failure of 034.promote_node.
@ 2025-12-17 09:07 Tatsuo Ishii <ishii@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Tatsuo Ishii @ 2025-12-17 09:07 UTC (permalink / raw)
  To: pgpool-committers@lists.postgresql.org

Test: fix occasional failure of 034.promote_node.

The error is caused by follow primary process. In the process
pg_rewind is executed to sync a standby with new primary. If new
primary promotion is slow, pg_rewind incorrectly returns "there's no
need to pg_rewind". Even if new standby starts, the standby causes an
error later on which make the 034.promote_node test failed.

To fix this, add CHECKPOINT in the failover script. Also add "-c"
option pg_rewind to retrieve WAL from archives so that pg_rewind could
find necessary WAL.

Reported-by: Bo Peng <pengbo@sraoss.co.jp>
Suggested-by: Bo Peng <pengbo@sraoss.co.jp>
Backpatch-through: v4.3

Branch
------
V4_6_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=61afab62abdc35e8da3ba18c86f63e89e3b97...

Modified Files
--------------
src/test/pgpool_setup.in | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgpool: Test: fix occasional failure of 034.promote_node.
@ 2025-12-17 09:07 Tatsuo Ishii <ishii@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Tatsuo Ishii @ 2025-12-17 09:07 UTC (permalink / raw)
  To: pgpool-committers@lists.postgresql.org

Test: fix occasional failure of 034.promote_node.

The error is caused by follow primary process. In the process
pg_rewind is executed to sync a standby with new primary. If new
primary promotion is slow, pg_rewind incorrectly returns "there's no
need to pg_rewind". Even if new standby starts, the standby causes an
error later on which make the 034.promote_node test failed.

To fix this, add CHECKPOINT in the failover script. Also add "-c"
option pg_rewind to retrieve WAL from archives so that pg_rewind could
find necessary WAL.

Reported-by: Bo Peng <pengbo@sraoss.co.jp>
Suggested-by: Bo Peng <pengbo@sraoss.co.jp>
Backpatch-through: v4.3

Branch
------
V4_7_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=9e3d0227bc3472af668a7fd193ad193e0afa7...

Modified Files
--------------
src/test/pgpool_setup.in | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgpool: Test: fix occasional failure of 034.promote_node.
@ 2025-12-17 09:07 Tatsuo Ishii <ishii@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Tatsuo Ishii @ 2025-12-17 09:07 UTC (permalink / raw)
  To: pgpool-committers@lists.postgresql.org

Test: fix occasional failure of 034.promote_node.

The error is caused by follow primary process. In the process
pg_rewind is executed to sync a standby with new primary. If new
primary promotion is slow, pg_rewind incorrectly returns "there's no
need to pg_rewind". Even if new standby starts, the standby causes an
error later on which make the 034.promote_node test failed.

To fix this, add CHECKPOINT in the failover script. Also add "-c"
option pg_rewind to retrieve WAL from archives so that pg_rewind could
find necessary WAL.

Reported-by: Bo Peng <pengbo@sraoss.co.jp>
Suggested-by: Bo Peng <pengbo@sraoss.co.jp>
Backpatch-through: v4.3

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=8d2ceadefcecf2b40d1df03003ec1ab8fe514...

Modified Files
--------------
src/test/pgpool_setup.in | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2025-12-17 09:07 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-12-17 09:06 pgpool: Test: fix occasional failure of 034.promote_node. Tatsuo Ishii <ishii@postgresql.org>
2025-12-17 09:07 pgpool: Test: fix occasional failure of 034.promote_node. Tatsuo Ishii <ishii@postgresql.org>
2025-12-17 09:07 pgpool: Test: fix occasional failure of 034.promote_node. Tatsuo Ishii <ishii@postgresql.org>
2025-12-17 09:07 pgpool: Test: fix occasional failure of 034.promote_node. Tatsuo Ishii <ishii@postgresql.org>
2025-12-17 09:07 pgpool: Test: fix occasional failure of 034.promote_node. Tatsuo Ishii <ishii@postgresql.org>
2025-12-17 09:07 pgpool: Test: fix occasional failure of 034.promote_node. Tatsuo Ishii <ishii@postgresql.org>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox