public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tatsuo Ishii <[email protected]>
To: [email protected]
Subject: pgpool: Fix duplicate NodeTag enum in nodes.h.
Date: Wed, 24 Dec 2025 08:06:00 +0000
Message-ID: <[email protected]> (raw)

Fix duplicate NodeTag enum in nodes.h.

The file was imported from PostgreSQL and Pgpool-II specific node type
were added right after T_Invalid = 0, then nodetags.h is
included. Since nodetags.h explicitly assign values to each enum
starting from 1, and this created duplicated enums.
T_List = 1,
T_Alias = 2,
T_RangeVar = 3,
T_PgpoolVariableSetStmt, (1)
T_PgpoolVariableShowStmt, (2)
T_PgpoolQueryCacheStmt, (3)

Although fortunately this seems does not create any trouble except the
duplicated enums, this should be fixed: moving the inclusion of
nodetags.h right after "T_invalid = 0".

Reported-by: liujinyang-highgo
Diagnosed-by: liujinyang-highgo
Discussion: https://github.com/pgpool/pgpool2/issues/138
Backpatch-through: v4.5

Branch
------
V4_6_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=9fcc5ba684c1b5c71759d563dd3caabd0cadd...

Modified Files
--------------
src/include/parser/nodes.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgpool: Fix duplicate NodeTag enum in nodes.h.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox