public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tatsuo Ishii <[email protected]>
To: [email protected]
Subject: pgpool: Fix walker functions to return earlier.
Date: Thu, 22 Jan 2026 04:30:13 +0000
Message-ID: <[email protected]> (raw)

Fix walker functions to return earlier.

Previously walker functions returned false once it found target
objects.  But it is possible to short-circuit the traverse and it
should have been.

Also import comments from PostgreSQL to clarify walker function
design.

Author: Tatsuo Ishii <[email protected]>
Reported-by: liujinyang-highgo
Backpatch-through: v4.3
Discussion: https://github.com/pgpool/pgpool2/issues/143

Branch
------
V4_3_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=64dda20f0070a6c64adb61433c07f89ea1c64...

Modified Files
--------------
src/rewrite/pool_timestamp.c   | 40 +++++++++++++++++++++++++++++++++++++++-
src/utils/pool_select_walker.c | 18 +++++++++---------
2 files changed, 48 insertions(+), 10 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgpool: Fix walker functions to return earlier.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox