agora inbox for pgpool-committers@postgresql.org
help / color / mirror / Atom feedpgpool: Add volatile qualifier.
6+ messages / 1 participants
[nested] [flat]
* pgpool: Add volatile qualifier.
@ 2026-07-21 12:01 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2026-07-21 12:01 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Add volatile qualifier.
In Pgpool-II main, local pointer array "my_backend_status" is not
volatile qualified, while it should have been.
Also in initialize_shared_mem_objects() and sync_backend_from_watchdog():
my_backend_status[i] = &(BACKEND_INFO(i).backend_status);
should have been:
my_backend_status[i] = (volatile BACKEND_STATUS *) &(BACKEND_INFO(i).backend_status);
Without these volatile qualifiers, *(my_backend_status[i]) could read
state value because of compiler optimization. Since
my_backend_status[i] is referred to in popular VALID_BACKEND macro, we
should fix it in all supported branches.
Author: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://www.postgresql.org/message-id/20260701.101148.451717746326656928.ishii%40postgresql.org
Backpatch-through: v4.3
Branch
------
V4_3_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=5e14a7f94f6312aff004b6bb4f58738e998f0...
Modified Files
--------------
src/include/pool.h | 2 +-
src/main/pgpool_main.c | 13 +++++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Add volatile qualifier.
@ 2026-07-21 12:01 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2026-07-21 12:01 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Add volatile qualifier.
In Pgpool-II main, local pointer array "my_backend_status" is not
volatile qualified, while it should have been.
Also in initialize_shared_mem_objects() and sync_backend_from_watchdog():
my_backend_status[i] = &(BACKEND_INFO(i).backend_status);
should have been:
my_backend_status[i] = (volatile BACKEND_STATUS *) &(BACKEND_INFO(i).backend_status);
Without these volatile qualifiers, *(my_backend_status[i]) could read
state value because of compiler optimization. Since
my_backend_status[i] is referred to in popular VALID_BACKEND macro, we
should fix it in all supported branches.
Author: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://www.postgresql.org/message-id/20260701.101148.451717746326656928.ishii%40postgresql.org
Backpatch-through: v4.3
Branch
------
V4_4_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=f62f4076bb60845ab66e6258749dba0716b3f...
Modified Files
--------------
src/include/pool.h | 2 +-
src/main/pgpool_main.c | 13 +++++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Add volatile qualifier.
@ 2026-07-21 12:01 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2026-07-21 12:01 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Add volatile qualifier.
In Pgpool-II main, local pointer array "my_backend_status" is not
volatile qualified, while it should have been.
Also in initialize_shared_mem_objects() and sync_backend_from_watchdog():
my_backend_status[i] = &(BACKEND_INFO(i).backend_status);
should have been:
my_backend_status[i] = (volatile BACKEND_STATUS *) &(BACKEND_INFO(i).backend_status);
Without these volatile qualifiers, *(my_backend_status[i]) could read
state value because of compiler optimization. Since
my_backend_status[i] is referred to in popular VALID_BACKEND macro, we
should fix it in all supported branches.
Author: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://www.postgresql.org/message-id/20260701.101148.451717746326656928.ishii%40postgresql.org
Backpatch-through: v4.3
Branch
------
V4_5_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=e7079755aa9315b31dbc109c984fdc137f741...
Modified Files
--------------
src/include/pool.h | 2 +-
src/main/pgpool_main.c | 13 +++++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Add volatile qualifier.
@ 2026-07-21 12:01 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2026-07-21 12:01 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Add volatile qualifier.
In Pgpool-II main, local pointer array "my_backend_status" is not
volatile qualified, while it should have been.
Also in initialize_shared_mem_objects() and sync_backend_from_watchdog():
my_backend_status[i] = &(BACKEND_INFO(i).backend_status);
should have been:
my_backend_status[i] = (volatile BACKEND_STATUS *) &(BACKEND_INFO(i).backend_status);
Without these volatile qualifiers, *(my_backend_status[i]) could read
state value because of compiler optimization. Since
my_backend_status[i] is referred to in popular VALID_BACKEND macro, we
should fix it in all supported branches.
Author: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://www.postgresql.org/message-id/20260701.101148.451717746326656928.ishii%40postgresql.org
Backpatch-through: v4.3
Branch
------
V4_6_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=f3250e05a78902c79ee18754899ddf7ddf4a0...
Modified Files
--------------
src/include/pool.h | 2 +-
src/main/pgpool_main.c | 13 +++++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Add volatile qualifier.
@ 2026-07-21 12:01 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2026-07-21 12:01 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Add volatile qualifier.
In Pgpool-II main, local pointer array "my_backend_status" is not
volatile qualified, while it should have been.
Also in initialize_shared_mem_objects() and sync_backend_from_watchdog():
my_backend_status[i] = &(BACKEND_INFO(i).backend_status);
should have been:
my_backend_status[i] = (volatile BACKEND_STATUS *) &(BACKEND_INFO(i).backend_status);
Without these volatile qualifiers, *(my_backend_status[i]) could read
state value because of compiler optimization. Since
my_backend_status[i] is referred to in popular VALID_BACKEND macro, we
should fix it in all supported branches.
Author: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://www.postgresql.org/message-id/20260701.101148.451717746326656928.ishii%40postgresql.org
Backpatch-through: v4.3
Branch
------
V4_7_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=84a079e639725b446815cd5e9e41ed009405e...
Modified Files
--------------
src/include/pool.h | 2 +-
src/main/pgpool_main.c | 13 +++++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Add volatile qualifier.
@ 2026-07-21 12:02 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2026-07-21 12:02 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Add volatile qualifier.
In Pgpool-II main, local pointer array "my_backend_status" is not
volatile qualified, while it should have been.
Also in initialize_shared_mem_objects() and sync_backend_from_watchdog():
my_backend_status[i] = &(BACKEND_INFO(i).backend_status);
should have been:
my_backend_status[i] = (volatile BACKEND_STATUS *) &(BACKEND_INFO(i).backend_status);
Without these volatile qualifiers, *(my_backend_status[i]) could read
state value because of compiler optimization. Since
my_backend_status[i] is referred to in popular VALID_BACKEND macro, we
should fix it in all supported branches.
Author: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://www.postgresql.org/message-id/20260701.101148.451717746326656928.ishii%40postgresql.org
Backpatch-through: v4.3
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=c2d464521ef017fd7aa76fc56c412c5af06fd...
Modified Files
--------------
src/include/pool.h | 2 +-
src/main/pgpool_main.c | 13 +++++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-07-21 12:02 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-21 12:01 pgpool: Add volatile qualifier. Tatsuo Ishii <ishii@postgresql.org>
2026-07-21 12:01 pgpool: Add volatile qualifier. Tatsuo Ishii <ishii@postgresql.org>
2026-07-21 12:01 pgpool: Add volatile qualifier. Tatsuo Ishii <ishii@postgresql.org>
2026-07-21 12:01 pgpool: Add volatile qualifier. Tatsuo Ishii <ishii@postgresql.org>
2026-07-21 12:01 pgpool: Add volatile qualifier. Tatsuo Ishii <ishii@postgresql.org>
2026-07-21 12:02 pgpool: Add volatile qualifier. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox