agora inbox for pgpool-committers@postgresql.orghelp / color / mirror / Atom feed
pgpool: Convert lifecheck_exit_handler to flag-only. 6+ messages / 1 participants [nested] [flat]
* pgpool: Convert lifecheck_exit_handler to flag-only. @ 2026-09-16 08:34 Taiki Koshino <koshino@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Taiki Koshino @ 2026-09-16 08:34 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Convert lifecheck_exit_handler to flag-only. The watchdog lifecheck exit handler performed non-async-signal-safe operations, including ereport(), wait(), pfree(), and exit(). The memory cleanup could also conflict with MemoryContext operations interrupted by the signal handler. Changes: Flag-only Signal Handler: Make lifecheck_exit_handler() only record the signal and set volatile sig_atomic_t flags while preserving errno. Normal-context Cleanup: Move child termination, cleanup, and process exit to process_lifecheck_exit_request(). Reported-by: Emond Papegaaij <emond.papegaaij@gmail.com> Reported-by: Claude Code Author: Taiki Koshino <koshino@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/OS9P286MB6486FF7EC3D412F5D9B2E45F94AE2%40OS9P286MB6486.JPNP286... Backpatch-through: v4.3 Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=493aedaa603fd34881ef75103a50e550a1073... Modified Files -------------- src/watchdog/wd_lifecheck.c | 50 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Convert lifecheck_exit_handler to flag-only. @ 2026-09-16 08:34 Taiki Koshino <koshino@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Taiki Koshino @ 2026-09-16 08:34 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Convert lifecheck_exit_handler to flag-only. The watchdog lifecheck exit handler performed non-async-signal-safe operations, including ereport(), wait(), pfree(), and exit(). The memory cleanup could also conflict with MemoryContext operations interrupted by the signal handler. Changes: Flag-only Signal Handler: Make lifecheck_exit_handler() only record the signal and set volatile sig_atomic_t flags while preserving errno. Normal-context Cleanup: Move child termination, cleanup, and process exit to process_lifecheck_exit_request(). Reported-by: Emond Papegaaij <emond.papegaaij@gmail.com> Reported-by: Claude Code Author: Taiki Koshino <koshino@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/OS9P286MB6486FF7EC3D412F5D9B2E45F94AE2%40OS9P286MB6486.JPNP286... Backpatch-through: v4.3 Branch ------ V4_7_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=f7373655c77b32a618ed3ec0d51ed8546f9bb... Modified Files -------------- src/watchdog/wd_lifecheck.c | 50 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Convert lifecheck_exit_handler to flag-only. @ 2026-09-16 08:35 Taiki Koshino <koshino@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Taiki Koshino @ 2026-09-16 08:35 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Convert lifecheck_exit_handler to flag-only. The watchdog lifecheck exit handler performed non-async-signal-safe operations, including ereport(), wait(), pfree(), and exit(). The memory cleanup could also conflict with MemoryContext operations interrupted by the signal handler. Changes: Flag-only Signal Handler: Make lifecheck_exit_handler() only record the signal and set volatile sig_atomic_t flags while preserving errno. Normal-context Cleanup: Move child termination, cleanup, and process exit to process_lifecheck_exit_request(). Reported-by: Emond Papegaaij <emond.papegaaij@gmail.com> Reported-by: Claude Code Author: Taiki Koshino <koshino@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/OS9P286MB6486FF7EC3D412F5D9B2E45F94AE2%40OS9P286MB6486.JPNP286... Backpatch-through: v4.3 Branch ------ V4_6_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=58d6e9f13265efd95b0299d76375bd84b4e5b... Modified Files -------------- src/watchdog/wd_lifecheck.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Convert lifecheck_exit_handler to flag-only. @ 2026-09-16 08:35 Taiki Koshino <koshino@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Taiki Koshino @ 2026-09-16 08:35 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Convert lifecheck_exit_handler to flag-only. The watchdog lifecheck exit handler performed non-async-signal-safe operations, including ereport(), wait(), pfree(), and exit(). The memory cleanup could also conflict with MemoryContext operations interrupted by the signal handler. Changes: Flag-only Signal Handler: Make lifecheck_exit_handler() only record the signal and set volatile sig_atomic_t flags while preserving errno. Normal-context Cleanup: Move child termination, cleanup, and process exit to process_lifecheck_exit_request(). Reported-by: Emond Papegaaij <emond.papegaaij@gmail.com> Reported-by: Claude Code Author: Taiki Koshino <koshino@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/OS9P286MB6486FF7EC3D412F5D9B2E45F94AE2%40OS9P286MB6486.JPNP286... Backpatch-through: v4.3 Branch ------ V4_5_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=59ff573ebb9fee03f078db58d0c6a475eacb2... Modified Files -------------- src/watchdog/wd_lifecheck.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Convert lifecheck_exit_handler to flag-only. @ 2026-09-16 08:36 Taiki Koshino <koshino@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Taiki Koshino @ 2026-09-16 08:36 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Convert lifecheck_exit_handler to flag-only. The watchdog lifecheck exit handler performed non-async-signal-safe operations, including ereport(), wait(), pfree(), and exit(). The memory cleanup could also conflict with MemoryContext operations interrupted by the signal handler. Changes: Flag-only Signal Handler: Make lifecheck_exit_handler() only record the signal and set volatile sig_atomic_t flags while preserving errno. Normal-context Cleanup: Move child termination, cleanup, and process exit to process_lifecheck_exit_request(). Reported-by: Emond Papegaaij <emond.papegaaij@gmail.com> Reported-by: Claude Code Author: Taiki Koshino <koshino@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/OS9P286MB6486FF7EC3D412F5D9B2E45F94AE2%40OS9P286MB6486.JPNP286... Backpatch-through: v4.3 Branch ------ V4_4_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=fccee62148a0766bb6c7c09d98ddeaf5d2463... Modified Files -------------- src/watchdog/wd_lifecheck.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Convert lifecheck_exit_handler to flag-only. @ 2026-09-16 08:36 Taiki Koshino <koshino@sraoss.co.jp> 0 siblings, 0 replies; 6+ messages in thread From: Taiki Koshino @ 2026-09-16 08:36 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Convert lifecheck_exit_handler to flag-only. The watchdog lifecheck exit handler performed non-async-signal-safe operations, including ereport(), wait(), pfree(), and exit(). The memory cleanup could also conflict with MemoryContext operations interrupted by the signal handler. Changes: Flag-only Signal Handler: Make lifecheck_exit_handler() only record the signal and set volatile sig_atomic_t flags while preserving errno. Normal-context Cleanup: Move child termination, cleanup, and process exit to process_lifecheck_exit_request(). Reported-by: Emond Papegaaij <emond.papegaaij@gmail.com> Reported-by: Claude Code Author: Taiki Koshino <koshino@sraoss.co.jp> Discussion: https://www.postgresql.org/message-id/OS9P286MB6486FF7EC3D412F5D9B2E45F94AE2%40OS9P286MB6486.JPNP286... Backpatch-through: v4.3 Branch ------ V4_3_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=4b978ae63679750f918e70cdf9ccfd8fd32fd... Modified Files -------------- src/watchdog/wd_lifecheck.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-09-16 08:36 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-16 08:34 pgpool: Convert lifecheck_exit_handler to flag-only. Taiki Koshino <koshino@sraoss.co.jp> 2026-09-16 08:34 pgpool: Convert lifecheck_exit_handler to flag-only. Taiki Koshino <koshino@sraoss.co.jp> 2026-09-16 08:35 pgpool: Convert lifecheck_exit_handler to flag-only. Taiki Koshino <koshino@sraoss.co.jp> 2026-09-16 08:35 pgpool: Convert lifecheck_exit_handler to flag-only. Taiki Koshino <koshino@sraoss.co.jp> 2026-09-16 08:36 pgpool: Convert lifecheck_exit_handler to flag-only. Taiki Koshino <koshino@sraoss.co.jp> 2026-09-16 08:36 pgpool: Convert lifecheck_exit_handler to flag-only. Taiki Koshino <koshino@sraoss.co.jp>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox