agora inbox for pgpool-committers@postgresql.org
help / color / mirror / Atom feedpgpool: Fix inconsistent internal transaction handling in Parse.
6+ messages / 1 participants
[nested] [flat]
* pgpool: Fix inconsistent internal transaction handling in Parse.
@ 2026-09-18 05:16 Taiki Koshino <koshino@sraoss.co.jp>
0 siblings, 0 replies; 6+ messages in thread
From: Taiki Koshino @ 2026-09-18 05:16 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix inconsistent internal transaction handling in Parse.
Parse() started an internal transaction for a strict query in raw mode:
if (!SL_MODE)
if (is_strict_query(...))
start_internal_transaction(...);
Bind() correctly limits the same operation to replication mode:
if (REPLICATION)
if (is_strict_query(...))
start_internal_transaction(...);
This difference left an autocommitted extended-protocol UPDATE in a
transaction in raw mode because the internal transaction was never
closed.
Add the REPLICATION condition to Parse() to make it consistent with
Bind().
The issue was verified using pgproto with the following extended-query
message sequence:
'P' "s" "UPDATE scm_pgpool_txn_probe SET value=value+1 WHERE id=1" 0
'B' "" "s" 0 0 0
'E' "" 0
'S'
'Y'
'X'
Before the fix, Pgpool-II returned:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(T)
After the fix, it returns:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(I)
Author: Taiki Koshino <koshino@sraoss.co.jp>
Discussion: https://github.com/pgpool/pgpool2/issues/172
Backpatch-through: v4.3
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=85f333b678d9acbbd0432dbcf68287d7cc853...
Modified Files
--------------
src/protocol/pool_proto_modules.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix inconsistent internal transaction handling in Parse.
@ 2026-09-18 05:17 Taiki Koshino <koshino@sraoss.co.jp>
0 siblings, 0 replies; 6+ messages in thread
From: Taiki Koshino @ 2026-09-18 05:17 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix inconsistent internal transaction handling in Parse.
Parse() started an internal transaction for a strict query in raw mode:
if (!SL_MODE)
if (is_strict_query(...))
start_internal_transaction(...);
Bind() correctly limits the same operation to replication mode:
if (REPLICATION)
if (is_strict_query(...))
start_internal_transaction(...);
This difference left an autocommitted extended-protocol UPDATE in a
transaction in raw mode because the internal transaction was never
closed.
Add the REPLICATION condition to Parse() to make it consistent with
Bind().
The issue was verified using pgproto with the following extended-query
message sequence:
'P' "s" "UPDATE scm_pgpool_txn_probe SET value=value+1 WHERE id=1" 0
'B' "" "s" 0 0 0
'E' "" 0
'S'
'Y'
'X'
Before the fix, Pgpool-II returned:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(T)
After the fix, it returns:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(I)
Author: Taiki Koshino <koshino@sraoss.co.jp>
Discussion: https://github.com/pgpool/pgpool2/issues/172
Backpatch-through: v4.3
Branch
------
V4_7_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=630e7da954202ae403b297a0f146672fcae4e...
Modified Files
--------------
src/protocol/pool_proto_modules.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix inconsistent internal transaction handling in Parse.
@ 2026-09-18 05:18 Taiki Koshino <koshino@sraoss.co.jp>
0 siblings, 0 replies; 6+ messages in thread
From: Taiki Koshino @ 2026-09-18 05:18 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix inconsistent internal transaction handling in Parse.
Parse() started an internal transaction for a strict query in raw mode:
if (!SL_MODE)
if (is_strict_query(...))
start_internal_transaction(...);
Bind() correctly limits the same operation to replication mode:
if (REPLICATION)
if (is_strict_query(...))
start_internal_transaction(...);
This difference left an autocommitted extended-protocol UPDATE in a
transaction in raw mode because the internal transaction was never
closed.
Add the REPLICATION condition to Parse() to make it consistent with
Bind().
The issue was verified using pgproto with the following extended-query
message sequence:
'P' "s" "UPDATE scm_pgpool_txn_probe SET value=value+1 WHERE id=1" 0
'B' "" "s" 0 0 0
'E' "" 0
'S'
'Y'
'X'
Before the fix, Pgpool-II returned:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(T)
After the fix, it returns:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(I)
Author: Taiki Koshino <koshino@sraoss.co.jp>
Discussion: https://github.com/pgpool/pgpool2/issues/172
Backpatch-through: v4.3
Branch
------
V4_6_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=c1149bb860d6173fbd28b94fd511b09071ff5...
Modified Files
--------------
src/protocol/pool_proto_modules.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix inconsistent internal transaction handling in Parse.
@ 2026-09-18 05:18 Taiki Koshino <koshino@sraoss.co.jp>
0 siblings, 0 replies; 6+ messages in thread
From: Taiki Koshino @ 2026-09-18 05:18 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix inconsistent internal transaction handling in Parse.
Parse() started an internal transaction for a strict query in raw mode:
if (!SL_MODE)
if (is_strict_query(...))
start_internal_transaction(...);
Bind() correctly limits the same operation to replication mode:
if (REPLICATION)
if (is_strict_query(...))
start_internal_transaction(...);
This difference left an autocommitted extended-protocol UPDATE in a
transaction in raw mode because the internal transaction was never
closed.
Add the REPLICATION condition to Parse() to make it consistent with
Bind().
The issue was verified using pgproto with the following extended-query
message sequence:
'P' "s" "UPDATE scm_pgpool_txn_probe SET value=value+1 WHERE id=1" 0
'B' "" "s" 0 0 0
'E' "" 0
'S'
'Y'
'X'
Before the fix, Pgpool-II returned:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(T)
After the fix, it returns:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(I)
Author: Taiki Koshino <koshino@sraoss.co.jp>
Discussion: https://github.com/pgpool/pgpool2/issues/172
Backpatch-through: v4.3
Branch
------
V4_5_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=2d23e0432fde85fa8058cc7abf115ce12162d...
Modified Files
--------------
src/protocol/pool_proto_modules.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix inconsistent internal transaction handling in Parse.
@ 2026-09-18 05:18 Taiki Koshino <koshino@sraoss.co.jp>
0 siblings, 0 replies; 6+ messages in thread
From: Taiki Koshino @ 2026-09-18 05:18 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix inconsistent internal transaction handling in Parse.
Parse() started an internal transaction for a strict query in raw mode:
if (!SL_MODE)
if (is_strict_query(...))
start_internal_transaction(...);
Bind() correctly limits the same operation to replication mode:
if (REPLICATION)
if (is_strict_query(...))
start_internal_transaction(...);
This difference left an autocommitted extended-protocol UPDATE in a
transaction in raw mode because the internal transaction was never
closed.
Add the REPLICATION condition to Parse() to make it consistent with
Bind().
The issue was verified using pgproto with the following extended-query
message sequence:
'P' "s" "UPDATE scm_pgpool_txn_probe SET value=value+1 WHERE id=1" 0
'B' "" "s" 0 0 0
'E' "" 0
'S'
'Y'
'X'
Before the fix, Pgpool-II returned:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(T)
After the fix, it returns:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(I)
Author: Taiki Koshino <koshino@sraoss.co.jp>
Discussion: https://github.com/pgpool/pgpool2/issues/172
Backpatch-through: v4.3
Branch
------
V4_4_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=68ba530c634aee24b9a4a78b9ac019af6a6a7...
Modified Files
--------------
src/protocol/pool_proto_modules.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix inconsistent internal transaction handling in Parse.
@ 2026-09-18 05:18 Taiki Koshino <koshino@sraoss.co.jp>
0 siblings, 0 replies; 6+ messages in thread
From: Taiki Koshino @ 2026-09-18 05:18 UTC (permalink / raw)
To: pgpool-committers@lists.postgresql.org
Fix inconsistent internal transaction handling in Parse.
Parse() started an internal transaction for a strict query in raw mode:
if (!SL_MODE)
if (is_strict_query(...))
start_internal_transaction(...);
Bind() correctly limits the same operation to replication mode:
if (REPLICATION)
if (is_strict_query(...))
start_internal_transaction(...);
This difference left an autocommitted extended-protocol UPDATE in a
transaction in raw mode because the internal transaction was never
closed.
Add the REPLICATION condition to Parse() to make it consistent with
Bind().
The issue was verified using pgproto with the following extended-query
message sequence:
'P' "s" "UPDATE scm_pgpool_txn_probe SET value=value+1 WHERE id=1" 0
'B' "" "s" 0 0 0
'E' "" 0
'S'
'Y'
'X'
Before the fix, Pgpool-II returned:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(T)
After the fix, it returns:
<= BE CommandComplete(UPDATE 1)
<= BE ReadyForQuery(I)
Author: Taiki Koshino <koshino@sraoss.co.jp>
Discussion: https://github.com/pgpool/pgpool2/issues/172
Backpatch-through: v4.3
Branch
------
V4_3_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=dc5aee297e04e2f23fbca9e6b6db40745730a...
Modified Files
--------------
src/protocol/pool_proto_modules.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-09-18 05:18 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-09-18 05:16 pgpool: Fix inconsistent internal transaction handling in Parse. Taiki Koshino <koshino@sraoss.co.jp>
2026-09-18 05:17 pgpool: Fix inconsistent internal transaction handling in Parse. Taiki Koshino <koshino@sraoss.co.jp>
2026-09-18 05:18 pgpool: Fix inconsistent internal transaction handling in Parse. Taiki Koshino <koshino@sraoss.co.jp>
2026-09-18 05:18 pgpool: Fix inconsistent internal transaction handling in Parse. Taiki Koshino <koshino@sraoss.co.jp>
2026-09-18 05:18 pgpool: Fix inconsistent internal transaction handling in Parse. Taiki Koshino <koshino@sraoss.co.jp>
2026-09-18 05:18 pgpool: Fix inconsistent internal transaction handling in Parse. Taiki Koshino <koshino@sraoss.co.jp>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox