pg.ddx.io  pgpool-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgpool: Fix handling of negotiate protocol version message.
2+ messages / 1 participants
[nested] [flat]

* pgpool: Fix handling of negotiate protocol version message.
@ 2026-05-29 08:39  Tatsuo Ishii <ishii@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Tatsuo Ishii @ 2026-05-29 08:39 UTC (permalink / raw)
  To: pgpool-committers@lists.postgresql.org

Fix handling of negotiate protocol version message.

ProcessNegotiateProtocol() saves NegotiateProtocolVersion message in a
Startup packet (sp->negotiateProtocolMsg) when initial connection to
backend is established. Unfortunately there was a bug with it.
Actually part of the message (unsupported optional messages) was not
saved. This prevented reusing the connection if frontend actually
checks unsupported optional messages are in the NegotiateProtocol
message.

This was discovered in PostgreSQL 19 beta while "greasing".
https://www.postgresql.org/message-id/DDZ539Z6JWSB.1BF62QDLBANQA%40jeltef.nl

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=7bcb55898a9a1fbac39dcecf5c9762f382132...

Modified Files
--------------
src/auth/pool_auth.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgpool: Fix handling of negotiate protocol version message.
@ 2026-11-18 02:43  Tatsuo Ishii <ishii@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Tatsuo Ishii @ 2026-11-18 02:43 UTC (permalink / raw)
  To: pgpool-committers@lists.postgresql.org

Fix handling of negotiate protocol version message.

ProcessNegotiateProtocol() saves NegotiateProtocolVersion message in a
Startup packet (sp->negotiateProtocolMsg) when initial connection to
backend is established. Unfortunately there was a bug with it.
Actually part of the message (unsupported optional messages) was not
saved. This prevented reusing the connection if frontend actually
checks unsupported optional messages are in the NegotiateProtocol
message.

This was discovered in PostgreSQL 19 beta while "greasing".
https://www.postgresql.org/message-id/DDZ539Z6JWSB.1BF62QDLBANQA%40jeltef.nl

This commit is a back port of commit on the master branch:
7bcb55898a9a1fbac39dcecf5c9762f38213237f

It was accidently forgot to port to 4.7. Since v4.7 we support the
NegotiateProtocolVersion message.

Branch
------
V4_7_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=7bc9624bfe1d752cb32bce592704b17b2204e...

Modified Files
--------------
src/auth/pool_auth.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-11-18 02:43 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-05-29 08:39 pgpool: Fix handling of negotiate protocol version message. Tatsuo Ishii <ishii@postgresql.org>
2026-11-18 02:43 pgpool: Fix handling of negotiate protocol version message. Tatsuo Ishii <ishii@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox