public inbox for [email protected]
help / color / mirror / Atom feedBug report: Hardcoded debug logs "pi->node_ids" in pcp_child (v4.7.0)
2+ messages / 2 participants
[nested] [flat]
* Bug report: Hardcoded debug logs "pi->node_ids" in pcp_child (v4.7.0)
@ 2026-04-06 11:14 JOSE MARIA Marin <[email protected]>
2026-04-07 08:55 ` Re: Bug report: Hardcoded debug logs "pi->node_ids" in pcp_child (v4.7.0) Koshino Taiki <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: JOSE MARIA Marin @ 2026-04-06 11:14 UTC (permalink / raw)
To: [email protected]
*Description:* After upgrading to PgPool-II 4.7.0, the logs are being
flooded with internal debug messages every time pcp_proc_info is executed.
*Log Example:* pcp_child pid XXXX: LOG: pi->node_ids[0]:1
pi->node_ids[1]:0. Repeats tens of times.
...
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:1
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:1
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3
pi->node_ids[1]:0
...
*Steps to reproduce:*
1.
Run PgPool-II 4.7.0.
2.
Execute pcp_proc_info.
3.
Check the main PgPool log.
*Current behavior:* Even with log_min_messages = warning and log_pcp_messages
= off, these messages persist. It seems like a hardcoded pool_log or fprintf
in the source code of the PCP child handler.
*Expected behavior:* Internal structure debugging like pi->node_ids should
only appear when debug_level is high or during development builds.
*Environment:*
-
PgPool-II version: 4.7.0
-
OS: Ubuntu (Docker)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Bug report: Hardcoded debug logs "pi->node_ids" in pcp_child (v4.7.0)
2026-04-06 11:14 Bug report: Hardcoded debug logs "pi->node_ids" in pcp_child (v4.7.0) JOSE MARIA Marin <[email protected]>
@ 2026-04-07 08:55 ` Koshino Taiki <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Koshino Taiki @ 2026-04-07 08:55 UTC (permalink / raw)
To: JOSE MARIA Marin <[email protected]>; [email protected] <[email protected]>
Hi,
Thank you for the report.
This has already been fixed. The debug messages were incorrectly emitted at LOG level, and have been downgraded to DEBUG5.
The fix will be included in the 4.7.2 release.
The related commit is here:
https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=f647c4a372ea2c2cfae80e4e60f209e236fe41ec
Best regards,
Taiki Koshino<[email protected]>
SRA OSS K.K.
TEL: 03-5979-2701 FAX: 03-5979-2702
URL: https://www.sraoss.co.jp/
________________________________
差出人: JOSE MARIA Marin <[email protected]>
送信日時: 2026年4月6日 20:14
宛先: [email protected] <[email protected]>
件名: Bug report: Hardcoded debug logs "pi->node_ids" in pcp_child (v4.7.0)
Description: After upgrading to PgPool-II 4.7.0, the logs are being flooded with internal debug messages every time pcp_proc_info is executed.
Log Example: pcp_child pid XXXX: LOG: pi->node_ids[0]:1 pi->node_ids[1]:0. Repeats tens of times.
...
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:1 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:1 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
2026-04-06 11:11:03.367: psql pid 188: LOG: pi->node_ids[0]:3 pi->node_ids[1]:0
...
Steps to reproduce:
1. Run PgPool-II 4.7.0.
2. Execute pcp_proc_info.
3. Check the main PgPool log.
Current behavior: Even with log_min_messages = warning and log_pcp_messages = off, these messages persist. It seems like a hardcoded pool_log or fprintf in the source code of the PCP child handler.
Expected behavior: Internal structure debugging like pi->node_ids should only appear when debug_level is high or during development builds.
Environment:
* PgPool-II version: 4.7.0
* OS: Ubuntu (Docker)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-04-07 08:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-04-06 11:14 Bug report: Hardcoded debug logs "pi->node_ids" in pcp_child (v4.7.0) JOSE MARIA Marin <[email protected]>
2026-04-07 08:55 ` Koshino Taiki <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox