Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uWvcg-003UDn-1a for pgpool-hackers@arkaria.postgresql.org; Wed, 02 Jul 2025 11:27:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uWvce-00GfoG-0o for pgpool-hackers@arkaria.postgresql.org; Wed, 02 Jul 2025 11:27:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uWvcd-00Gfnd-RA for pgpool-hackers@lists.postgresql.org; Wed, 02 Jul 2025 11:27:28 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uWvcc-0058jh-0m for pgpool-hackers@lists.postgresql.org; Wed, 02 Jul 2025 11:27:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type: Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender :Reply-To:Content-ID:Content-Description; bh=y3psuu9ssFGo42nmCuTe5zpmi8xtMZlIP3wvFOc0vDU=; b=5E5q4FujlazKPcpm4unXq41YAp DB6VMb6gSMS94Zxig9Qr2qiRpVOrmAa7zJyztbTEidiwAxXfbAVvOmM1Ww4q59rjHmS0b8hFWm4zM ZSbxB9uVweXZQK1Os19GNzYi3hDjgDTrpvfHvsxAAwUfWJAdqa0Re1yNt/owCmcmvbSGfaLB71dJH 54t7Ws9zKL831lzUyyQPyV21mtZuIvXzl3UQRcF5Pd6f96zw+Kcfjfk6qoAhVP3PjuRCV3dNsiqpn vJcToZrTi6HVOA2KQJ6zq0mkqiA/zW4TfU03k3lJ4HI8zW8ZpKn2ZjpoQy4izw2BKaW28wrZLjZmi mqIveuHg==; Received: from [2409:11:4120:300:abc7:6fda:3224:18ca] (helo=localhost) by meldrar.postgresql.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1uWvcY-002Lh4-1Z; Wed, 02 Jul 2025 11:27:25 +0000 Date: Wed, 02 Jul 2025 20:27:13 +0900 (JST) Message-Id: <20250702.202713.220401050993902307.ishii@postgresql.org> To: koshino@sraoss.co.jp Cc: pgpool-hackers@lists.postgresql.org Subject: Re: Patch for fixing doc about some parameters. From: Tatsuo Ishii In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2409:11:4120:300:abc7:6fda:3224:18ca (failed) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > Fixed mistakes in the documentation for parameters. > > "v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch" > is a patch for ticket #10954 > "Test all the configuration parameters if reload is required." There's one trainling whitespace. $ git apply ~/v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch /home/t-ishii/v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch:39: trailing whitespace. このパラメータはサーバ起動時にのみ設定可能です。 warning: 1 line adds whitespace errors. > Subject: [PATCH v2] Fixed documentation for parameters that are not reflected by reload. This comes from the commit title "Fixed documentation for parameters that are not reflected by reload." We usually add "Doc:" prefix to the commit header if the changes are only for documentations. Also "Fixed" seems unnatural as a commit header. Instead use "fix". So something like "Doc: fix documentation for parameters that are not reflected by reload." is better, > "v1-0001-Fix-documentation-for-enum-parameters-reported-as" > is for ticket #8397 Please add "Doc:" prefix to the commit title as well. #8397 is an internal number and you'd better to remove it. Other than that, the patch looks good to me. Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp