Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uvmRP-001ROl-Ej for pgpool-hackers@arkaria.postgresql.org; Tue, 09 Sep 2025 00:42:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uvmRN-008dc2-0L for pgpool-hackers@arkaria.postgresql.org; Tue, 09 Sep 2025 00:42:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uvmRM-008dbu-RB for pgpool-hackers@lists.postgresql.org; Tue, 09 Sep 2025 00:42:33 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uvmRJ-001IS9-25 for pgpool-hackers@lists.postgresql.org; Tue, 09 Sep 2025 00:42:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type: Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender :Reply-To:Content-ID:Content-Description; bh=rUiWUIGXaED+G/hga+PuhLZbqyV+OikSITf/bGG3kWI=; b=Zz2osjZOBt6RJI5VEAJopVpBjX zvP18KzshtEP8kCp07Q+Pdd13RsULuf1FGx8nDYMEqmdNIP9Sg4sTLOWBOhR3cCX+W+nFaNKegOs+ rtmJjxQguJ/+/upFJN6QZvu/TrB97JLwYopMzSTMUcv0OBtVndF6kvmZGt0aYJ+xOM7PkvOxUEF8U p+IAWnSGe/XY3eums7Fgf5xKYLBCi4wHLIvLcbu4bMeUG2ZwjVdQfy/xrLTkaEIlIUQ2YxBmllNdt sCaYDqqNMlEkKZwcJGJwNyQP91X/YQJQ0vRahg6yKpCRiyYx4IK/kRuWUs4x3D8vmW2O0u/Nk5/rt onzovX+Q==; Received: from [2409:11:4120:300:6530:1321:7773:99c0] (helo=localhost) by meldrar.postgresql.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uvmRH-002qJo-19; Tue, 09 Sep 2025 00:42:30 +0000 Date: Tue, 09 Sep 2025 09:39:44 +0900 (JST) Message-Id: <20250909.093944.156562835222886259.ishii@postgresql.org> To: nadav@tailorbrands.com Cc: pgpool-hackers@lists.postgresql.org Subject: Re: Proposal: recent access based routing for primary-replica setups From: Tatsuo Ishii In-Reply-To: References: <20250908.092628.942175382089863152.ishii@postgresql.org> X-Mailer: Mew version 6.8 on Emacs 29.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2409:11:4120:300:6530:1321:7773:99c0 (failed) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Nadav, > Hi Tatsuo, > > Please find attached the 3 patch files (implementation, tests, docs) with > the updates we discussed. > > What do you think? I haven't read the code details yet but I have a few questions. 1) Can we use only replication_delay_source_cmd and if it's value is 'builtin', then we treat it as replication_delay_source = builtin? Maybe this is matter of taste but I would like to know your opinion. 2) replication_delay_source_cmd will be given an ordered list of instance identifiers. But it seems there's no way for the command which one is the primary instance. Is it okay for the command? 3) Why do you have 3 kind of instance identifiers (application name, hostname (IP) + port and node id? I thought "hostname (IP) + port" is sufficient. Comments? -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp