public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: pg_enc
Date: Wed, 24 Sep 2025 09:55:27 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
>> attatch is the patch for this issue, please help review it.
>
> Thanks. I will look into to the patch. In the mean time I discarded
> the pending message previously sent.
The patch looks good to me. I am going to push to all supported
branches (down to 4.2). Also I will update the misleading comment
(this is unrelated to the issue you pointed out, though). See attached
patch.
BTW, to credit you as the original author of the patch, I would like
to ask you what you would like to be credited your name and
email. Usually I pick up it from the email From: like this,
Author: Tatsuo Ishii <[email protected]>
But since you have your name in Chinese in the From: field, I cannot
include it in the commit message. Can you provide your name in ASCII
letters? Or you can omit it and the Author field would become:
Author: [email protected]
It's up to your choice.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Attachments:
[application/octet-stream] v2_pg_enc.patch (914B, 2-v2_pg_enc.patch)
download | inline diff:
diff --git a/src/tools/pgenc/pg_enc.c b/src/tools/pgenc/pg_enc.c
index 83c6d3b4f..7e5143843 100644
--- a/src/tools/pgenc/pg_enc.c
+++ b/src/tools/pgenc/pg_enc.c
@@ -5,7 +5,7 @@
* pgpool: a language independent connection pool server for PostgreSQL
* written by Tatsuo Ishii
*
- * Copyright (c) 2003-2022 PgPool Global Development Group
+ * Copyright (c) 2003-2025 PgPool Global Development Group
*
* Permission to use, copy, modify, and distribute this software and
* its documentation for any purpose and without fee is hereby
@@ -98,7 +98,7 @@ main(int argc, char *argv[])
{
switch (opt)
{
- case 'p': /* prompt for postgres password */
+ case 'p': /* prompt for password to be encrypted */
prompt = true;
break;
@@ -246,6 +246,7 @@ main(int argc, char *argv[])
exit(EXIT_FAILURE);
}
stpncpy(enc_key, buf, sizeof(enc_key));
+ pool_key = enc_key;
}
else
{
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pg_enc
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox