public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: Proposal: recent access based routing for primary-replica setups
Date: Mon, 03 Nov 2025 16:05:34 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACeKOO25iz+fik4_JqZeE8VbLe=TPCCocMABQQgzcJYioaWhHA@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CACeKOO25iz+fik4_JqZeE8VbLe=TPCCocMABQQgzcJYioaWhHA@mail.gmail.com>
> thanks and sorry for the issues, please find attached updated version.
No problem.
This time the patch applies fine, no compiler warnings. However,
regression test did not passed here (on Ubuntu 24 LTS if this
matters). So I looked into
src/test/regression/tests/041.external_replication_delay/test.sh a
little bit and apply attached patch (test.sh.patch). It moved forward
partially but failed at:
fail: command execution failure not detected
Please find attached
src/test/regression/tests/041.external_replication_delay/testdir/pgpool.log
and src/test/regression/log/041.external_replication_delay.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Attachments:
[application/octet-stream] test.sh.patch (1.4K, 2-test.sh.patch)
download | inline diff:
*** src/test/regression/tests/041.external_replication_delay/test.sh 2025-11-03 15:27:29.630972600 +0900
--- /tmp/test.sh 2025-11-03 15:22:31.503487058 +0900
***************
*** 217,223 ****
EOF
# With high delays (2000ms > 1000ms threshold), query should go to primary (node 0)
! grep "SELECT \* FROM t1 LIMIT 1.*DB node id: 0" log/pgpool.log >/dev/null 2>&1
if [ $? != 0 ];then
echo fail: query was not sent to primary node despite high delay
./shutdownall
--- 217,223 ----
EOF
# With high delays (2000ms > 1000ms threshold), query should go to primary (node 0)
! grep "DB node id: 0 backend pid: [0-9]* statement: SELECT \* FROM t1 LIMIT 1;" log/pgpool.log >/dev/null 2>&1
if [ $? != 0 ];then
echo fail: query was not sent to primary node despite high delay
./shutdownall
***************
*** 277,283 ****
# No specific error message expected - just verify it doesn't crash
sleep 3
! echo ok: empty command test succeeded (fallback to builtin)
./shutdownall
# ----------------------------------------------------------------------------------------
--- 277,283 ----
# No specific error message expected - just verify it doesn't crash
sleep 3
! echo "ok: empty command test succeeded (fallback to builtin)"
./shutdownall
# ----------------------------------------------------------------------------------------
[application/octet-stream] pgpool.log (36.8K, 3-pgpool.log)
download
[application/octet-stream] 041.external_replication_delay (18.5K, 4-041.external_replication_delay)
download
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Proposal: recent access based routing for primary-replica setups
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox