public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: Proposal: recent access based routing for primary-replica setups
Date: Thu, 20 Nov 2025 08:09:30 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACeKOO3kSTnAsjQMmuYFAFDG513W4KeAX=vZ7NVaFafMy9KFXQ@mail.gmail.com>
References: <CACeKOO2Xeg5nGGhwj-JUa7wgFekZtfGeCkMKLbdG1EoY4N5YSA@mail.gmail.com>
	<[email protected]>
	<CACeKOO3kSTnAsjQMmuYFAFDG513W4KeAX=vZ7NVaFafMy9KFXQ@mail.gmail.com>

Hi Nadav,

Thank you for new patch.
Unfortunately the patch did not apply to current master.

$ git apply ~/0001-Fix-multiple-issues-in-external-replication-delay-fe.patch 
error: patch failed: src/streaming_replication/pool_worker_child.c:694
error: src/streaming_replication/pool_worker_child.c: patch does not apply

Maybe the patch is on top of your previous patch?

Also I suggest to use "-v" option of "git format-patch" to add the
patch version number so that we can easily know which patch is the
latest.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

> Hi Tatsuo,
> 
> Please see attached an updated version.
> 
> thank you
> 
> On Fri, Nov 7, 2025 at 2:07 AM Tatsuo Ishii <[email protected]> wrote:
> 
>> > Sorry for that - thanks for the patch.
>> >
>> > Please find attached a new version
>>
>> Thanks for the new version. Unfortunately this time regression test
>> fails at:
>>
>> > Waiting for command timeout...
>> > fail: command timeout not detected
>>
>> Attached is the pgpool.log.
>>
>> Best regards,
>> --
>> Tatsuo Ishii
>> SRA OSS K.K.
>> English: http://www.sraoss.co.jp/index_en/
>> Japanese:http://www.sraoss.co.jp
>>
>> > On Mon, Nov 3, 2025 at 9:05 AM Tatsuo Ishii <[email protected]>
>> wrote:
>> >
>> >> > thanks and sorry for the issues, please find attached updated version.
>> >>
>> >> No problem.
>> >>
>> >> This time the patch applies fine, no compiler warnings.  However,
>> >> regression test did not passed here (on Ubuntu 24 LTS if this
>> >> matters).  So I looked into
>> >> src/test/regression/tests/041.external_replication_delay/test.sh a
>> >> little bit and apply attached patch (test.sh.patch). It moved forward
>> >> partially but failed at:
>> >>
>> >> fail: command execution failure not detected
>> >>
>> >> Please find attached
>> >>
>> src/test/regression/tests/041.external_replication_delay/testdir/pgpool.log
>> >> and src/test/regression/log/041.external_replication_delay.
>> >>
>> >> Best regards,
>> >> --
>> >> Tatsuo Ishii
>> >> SRA OSS K.K.
>> >> English: http://www.sraoss.co.jp/index_en/
>> >> Japanese:http://www.sraoss.co.jp
>> >>
>> >
>> >
>> > --
>> > Nadav Shatz
>> > Tailor Brands | CTO
>>
> 
> 
> -- 
> Nadav Shatz
> Tailor Brands | CTO

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Proposal: recent access based routing for primary-replica setups
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox