Date: Mon, 15 Dec 2025 09:18:51 +0900 (JST)
Message-Id: <20251215.091851.1058501454610792105.ishii@postgresql.org>
To: pgpool-hackers@lists.postgresql.org
Subject: Re: Feature: add sync message logging to log_per_node_statement
 and notice_per_node_statement
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <20251214.220231.820411055090373414.ishii@postgresql.org>
References: <20251214.220231.820411055090373414.ishii@postgresql.org>
Mime-Version: 1.0
Content-Type: Multipart/Mixed;
 boundary="--Next_Part(Mon_Dec_15_09_18_51_2025_306)--"
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20251215.091851.1058501454610792105.ishii%40postgresql.org>
Precedence: bulk

----Next_Part(Mon_Dec_15_09_18_51_2025_306)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

> Currently pgpool does not emit logs for a "sync" message when
> log_per_node_statement/notice_per_node_statement enabled. Although
> "sync" is not a query statement, I think a sync message plays
> important role in extended query protocol since it indicates the
> completion of series of extended query protocol messages, and logging
> a sync message is important in a trouble shooting (I myself often
> enable debug message just to know whether a sync message is sent to
> backend or not, but enabling debug message creates lots of noise). So
> I propose to add logging for a sync message for upcoming Pgpool-II
> 4.8.
> 
> Comments or suggestions are welcome.

Patch attached.
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

----Next_Part(Mon_Dec_15_09_18_51_2025_306)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="log_sync_message.patch"

diff --git a/src/protocol/pool_process_query.c b/src/protocol/pool_process_query.c
index 96334f8e0..0dacbcbc4 100644
--- a/src/protocol/pool_process_query.c
+++ b/src/protocol/pool_process_query.c
@@ -879,6 +879,14 @@ SimpleForwardToBackend(char kind, POOL_CONNECTION *frontend,
 
 				pool_write(CONNECTION(backend, i), &kind, 1);
 				pool_write_and_flush(CONNECTION(backend, i), &sendlen, sizeof(sendlen));
+				/* If sync message, emit log */
+				if (kind == 'S')
+				{
+					char	   *str = "Sync";
+
+					per_node_statement_log(backend, i, str);
+					per_node_statement_notice(backend, i, str);
+				}
 			}
 		}
 		return POOL_CONTINUE;

----Next_Part(Mon_Dec_15_09_18_51_2025_306)----