Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vVhDu-006QdF-1k for pgpool-hackers@arkaria.postgresql.org; Wed, 17 Dec 2025 02:25:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vVhDt-009UiI-1b for pgpool-hackers@arkaria.postgresql.org; Wed, 17 Dec 2025 02:25:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vVhDt-009UiB-12 for pgpool-hackers@lists.postgresql.org; Wed, 17 Dec 2025 02:25:06 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vVhDs-0014Td-14 for pgpool-hackers@lists.postgresql.org; Wed, 17 Dec 2025 02:25:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type: Mime-Version:References:In-Reply-To:From:Subject:To:Message-Id:Date:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=Q1UjQZchQ00xrO+Qy4sNnb7DRbXoKjwzDKfDhmUVRXU=; b=PAkfa13khUjJj82NuOpsPWlXhu /kjoIIY9gnEDNhIa9ZY5tfZfVB6sZYeL0bCwVpunwfv2Tp5qvGl28flpq4NDQsbJLOZwQeWVmGLLh LHpXxtYcVnqkKtQXnQ1sBNvjHPhoJ/9pNZ3Lt/amL9sOpnkycTpKn4A9/H8XK23Vd76GJZ9RkSb3t YXcfR+4guD5q2EcsT7nKNSorJ6LzbKqxYuxqGz8OqMnEw5fLne/u9HwyDTjsTUMQEj6JkmIZM3fqO rejYu2gj8705jTRfbxhhcC/poAAJj72EQvXvdDNOGbMzzMgcOoJcH5s1t+7kq8jgFN+YMrb8BQtG2 U3gSWt9w==; Received: from [2409:11:4120:300:60bd:dbaa:488:1e49] (helo=localhost) by meldrar.postgresql.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vVhDo-0026yE-0p for pgpool-hackers@lists.postgresql.org; Wed, 17 Dec 2025 02:25:02 +0000 Date: Wed, 17 Dec 2025 11:24:53 +0900 (JST) Message-Id: <20251217.112453.100409863857130977.ishii@postgresql.org> To: pgpool-hackers@lists.postgresql.org Subject: Re: Feature: add sync message logging to log_per_node_statement and notice_per_node_statement From: Tatsuo Ishii In-Reply-To: <20251215.091851.1058501454610792105.ishii@postgresql.org> References: <20251214.220231.820411055090373414.ishii@postgresql.org> <20251215.091851.1058501454610792105.ishii@postgresql.org> X-Mailer: Mew version 6.8 on Emacs 29.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2409:11:4120:300:60bd:dbaa:488:1e49 (failed) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk >> Currently pgpool does not emit logs for a "sync" message when >> log_per_node_statement/notice_per_node_statement enabled. Although >> "sync" is not a query statement, I think a sync message plays >> important role in extended query protocol since it indicates the >> completion of series of extended query protocol messages, and logging >> a sync message is important in a trouble shooting (I myself often >> enable debug message just to know whether a sync message is sent to >> backend or not, but enabling debug message creates lots of noise). So >> I propose to add logging for a sync message for upcoming Pgpool-II >> 4.8. >> >> Comments or suggestions are welcome. > > Patch attached. Patch pushed to master branch. Thanks. -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp